Merge pull request #583 from LeetCode-OpenSource/fix/test

fix: teardown test should work

Author: Miloas

jest.config.js

@@ -1,5 +1,4 @@
 module.exports = {
-  browser: true,
   verbose: true,
   rootDir: __dirname,
   setupFilesAfterEnv: ['<rootDir>/tools/test-setup.js'],

package.json

@@ -28,6 +28,7 @@
     "@types/sinon": "^9.0.0",
     "@types/sinon-chai": "^3.2.3",
     "@types/webpack": "^4.41.0",
+    "browser-resolve": "^2.0.0",
     "codecov": "^3.6.1",
     "fork-ts-checker-webpack-plugin": "^6.0.0",
     "happypack": "^5.0.1",
@@ -81,5 +82,8 @@
     "hooks": {
       "pre-commit": "lint-staged"
     }
+  },
+  "jest": {
+    "resolver": "browser-resolve"
   }
 }

src/__test__/use-event-callback.spec.tsx

@@ -46,12 +46,7 @@ describe('useEventCallback specs', () => {
     const timer = Sinon.useFakeTimers()
     const timeToDelay = 200
     const value = 1
-    const Fixture = createFixture((event$: Observable<any>) =>
-      event$.pipe(
-        mapTo(value),
-        delay(timeToDelay),
-      ),
-    )
+    const Fixture = createFixture((event$: Observable<any>) => event$.pipe(mapTo(value), delay(timeToDelay)))
     const fixtureNode = <Fixture />
     const testRenderer = create(fixtureNode)
     act(() => testRenderer.update(fixtureNode))
@@ -69,11 +64,7 @@ describe('useEventCallback specs', () => {
     const value = 1
     const timeToDelay = 200
     const Fixture = createFixture(
-      (event$: Observable<any>) =>
-        event$.pipe(
-          mapTo(value),
-          delay(timeToDelay),
-        ),
+      (event$: Observable<any>) => event$.pipe(mapTo(value), delay(timeToDelay)),
       initialValue,
     )
     const fixtureNode = <Fixture />
@@ -189,7 +180,9 @@ describe('useEventCallback specs', () => {
     )
     const fixtureNode = <Fixture />
     const testRenderer = create(fixtureNode)
-    testRenderer.unmount()
+    act(() => {
+      testRenderer.unmount()
+    })
     expect(spy.callCount).toBe(1)
   })
 })

src/__test__/use-observable.spec.tsx

@@ -71,7 +71,9 @@ describe('useObservable specs', () => {
 
     const testRenderer = create(fixtureNode)
     expect(spy.callCount).toBe(0)
-    testRenderer.unmount()
+    act(() => {
+      testRenderer.unmount()
+    })
     expect(spy.callCount).toBe(1)
   })