Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image proxying/caching only seems to work for thumbnails? #5538

Closed
3 tasks done
Die4Ever opened this issue Mar 23, 2025 · 5 comments
Closed
3 tasks done

image proxying/caching only seems to work for thumbnails? #5538

Die4Ever opened this issue Mar 23, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@Die4Ever
Copy link

Requirements

  • This is a feature request and not a bug report. Otherwise, please create a new bug report instead.
  • Please check to see if this request (or a similar one) already exists.
  • It's a single feature. Please don't request multiple features in one issue.

Describe the feature you'd like

I thought this option would do it for the full images too, maybe that's not the intention so I'm filing this as a feature request.

example: https://lemmy.ml/post/27523111

Image

Image

I realized this because I was trying to help a frustrated user: https://old.reddit.com/r/Lemmy/comments/1jhqk58/is_there_a_way_to_browse_lemmy_without_requesting/

@Die4Ever Die4Ever added the enhancement New feature or request label Mar 23, 2025
@dessalines dessalines transferred this issue from LemmyNet/lemmy-ui Mar 24, 2025
@dessalines
Copy link
Member

@Nutomic I looked through crates/apub/src/objects/post.rs, but I don't see any calls to proxy_image_link in the from_json, like we do for local image creation.

@Nutomic
Copy link
Member

Nutomic commented Mar 25, 2025

Right this seems to be missing.

@Die4Ever
Copy link
Author

Die4Ever commented Mar 27, 2025

I also see unproxied images in PMs

Image

images in PMs should maybe be hidden by default for security? proxying might not be good enough security in the case of PMs

https://retrolemmy.com/comment/11825421

@dessalines
Copy link
Member

That's a separate, UI related issue.

@Nutomic
Copy link
Member

Nutomic commented Mar 28, 2025

@Die4Ever I checked the code and it definitely does proxying for those. Are you sure the setting is enabled on your instance?

Nutomic added a commit that referenced this issue Mar 28, 2025
MrKaplan-lw pushed a commit to Fedihosting-Foundation-Forks/lemmy that referenced this issue Mar 29, 2025
Nutomic added a commit that referenced this issue Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants