Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Remove post.instance_id column #5544

Closed
5 tasks done
dessalines opened this issue Mar 25, 2025 · 1 comment · Fixed by #5546
Closed
5 tasks done

[Bug]: Remove post.instance_id column #5544

dessalines opened this issue Mar 25, 2025 · 1 comment · Fixed by #5546
Labels
bug Something isn't working
Milestone

Comments

@dessalines
Copy link
Member

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support or the matrix chat.
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Do you agree to follow the rules in our Code of Conduct?
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

The post's instance_id column is a dupe of the community's instance_id column, and its also not being set correctly.

It should be removed.

Steps to Reproduce

NA

Technical Details

NA

Version

main

Lemmy Instance URL

all

@dessalines dessalines added the bug Something isn't working label Mar 25, 2025
@dessalines dessalines added this to the 1.0.0 milestone Mar 25, 2025
@Nutomic
Copy link
Member

Nutomic commented Mar 25, 2025

This was moved over from post_aggregates, iirc it was meant to optimize some sql queries. The logic to initialize it may have been lost in #5407. Using community.instance_id makes sense as its more explicit, otherwise its not clear whether you are getting that or getting person.instance_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants