Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federate content of a searched post or comment #5554

Open
5 tasks done
Fmstrat opened this issue Mar 27, 2025 · 4 comments
Open
5 tasks done

Federate content of a searched post or comment #5554

Fmstrat opened this issue Mar 27, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@Fmstrat
Copy link

Fmstrat commented Mar 27, 2025

Requirements

  • Is this a feature request? For questions or discussions use https://lemmy.ml/c/lemmy_support or the matrix chat.
  • Did you check to see if this issue already exists?
  • Is this only a feature request? Do not put multiple feature requests in one issue.
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.
  • Do you agree to follow the rules in our Code of Conduct?

Is your proposal related to a problem?

Assumptions:

  • I am browsing the web and come across a comment on a post on an instance that I would like to participate in
  • My home instance may or may not be federated with this instance yet
  • No user on my home instance is subscribed to the community
  • Due to the above, the post does not exist on my instance

Action: Search post

  • I search for the post on my home instance by putting in the URL of https://other.instance/post/1234
  • The post and community are federated to my instance during the search, and the result pops up
  • However, no comments or votes come over, so I am unable to respond to the initial comment

Describe the solution you'd like.

When searching for a post on another instance, that post should begin federating and backfill content. Preferably new content specific to that post would also federate if a user on the local instance interacts with it (comment/vote/save).

Describe alternatives you've considered.

Searching every individual comment fedilink, which is not really feasible.

Additional context

Apologies if this has come up before, I swear I saw something similar but less detailed a loooong time ago, but could not find it anywhere. I also don't think it was exactly this.

@Fmstrat Fmstrat added the enhancement New feature or request label Mar 27, 2025
@matc-pub
Copy link
Contributor

matc-pub commented Mar 27, 2025

lemmy-ui changed comment links to include the post id. The old links (https://other.instance/comment/0987) still work.

Edit: The fedilink (next to comment direct link) still has the old format.

@Fmstrat
Copy link
Author

Fmstrat commented Mar 28, 2025

lemmy-ui changed comment links to include the post id. The old links (https://other.instance/comment/0987) still work.

Edit: The fedilink (next to comment direct link) still has the old format.

I'm not sure I know what you mean by "next to comment direct link" as I only see the one link, but searching for https://other.instance/comment/0987 does not work either. Content is not federated post search, and the comment is not pulled into the local server.

Edit: I have updated the report yo include that format as well.

Edit2: Found what you meant by Fedilink, but it too fails (same format as updated report).

@Fmstrat
Copy link
Author

Fmstrat commented Mar 28, 2025

@matc-pub Actually, that part may be a bug.

  • Top-level comments from users on the same I instance as the post federate when you search the comment fedilink.
  • No comments federate from users on another instance
  • Lower level comments do not federate when searched, at least if the parent comment is not from the original instance

For instance, if I search a post that was made on lemm.ee it federates to my server. If I search a comment that was made on that post by a user on lemmy.world, it doesnt federate. It doesnt matter if you search the UI comment link or the fedilink.

I wonder if the local server doesn't think a parent exists because of the mismatch in host, even though that's valid.

@Fmstrat
Copy link
Author

Fmstrat commented Mar 28, 2025

Annnnd that may have been a one-off federation issue. Using the fedilink works every other time. Ugh, inconsistencies will be the death of me.

I am updating the above feature request to focus only on federating the content once a user has interacted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants