-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update pyproject.toml tool.ruff target to py310
#21334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update pyproject.toml tool.ruff target to py310
#21334
Conversation
38b7936 to
e052da7
Compare
for more information, see https://pre-commit.ci
|
@matsumotosan I think #21344 needs to be merged before tests can pass for this PR |
|
@SkafteNicki I agree. I figured I could take a look at the changes the linter would make since it would be a lot. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21334 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 269 269
Lines 23744 23746 +2
=======================================
- Hits 20572 20571 -1
- Misses 3172 3175 +3 |
bhimrazy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Update ruff target version to Python 3.10 as part of #21304
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21334.org.readthedocs.build/en/21334/