feat(video): add support for legacy MPEG-2 and H.263+ encoders

Author: ReenigneArcher

docs/configuration.md

@@ -2124,6 +2124,85 @@ editing the `conf` file in a text editor. Use the examples as reference.
     </tr>
 </table>
 
+### mpeg2_mode
+
+<table>
+    <tr>
+        <td>Description</td>
+        <td colspan="2">
+            Allows compatibility clients to request MPEG-2/H.262 video streams. Automatic mode keeps this legacy codec
+            below H.264, HEVC, and AV1 by not advertising it unless explicitly forced. When forced, Sunshine may use a
+            legacy-capable fallback encoder for MPEG-2 streams without changing the encoder used for modern codecs.
+            @warning{MPEG-2 may be more CPU-intensive to encode than modern hardware-accelerated codecs when hardware
+            encoding is unavailable.}
+        </td>
+    </tr>
+    <tr>
+        <td>Default</td>
+        <td colspan="2">@code{}
+            0
+            @endcode</td>
+    </tr>
+    <tr>
+        <td>Example</td>
+        <td colspan="2">@code{}
+            mpeg2_mode = 2
+            @endcode</td>
+    </tr>
+    <tr>
+        <td rowspan="3">Choices</td>
+        <td>0</td>
+        <td>preserve modern codec automatic selection and keep MPEG-2 unadvertised</td>
+    </tr>
+    <tr>
+        <td>1</td>
+        <td>do not advertise support for MPEG-2</td>
+    </tr>
+    <tr>
+        <td>2</td>
+        <td>advertise support for MPEG-2/H.262 video</td>
+    </tr>
+</table>
+
+### h263p_mode
+
+<table>
+    <tr>
+        <td>Description</td>
+        <td colspan="2">
+            Allows compatibility clients to request H.263+ video streams. Automatic mode keeps this legacy codec below
+            H.264, HEVC, and AV1 by not advertising it unless explicitly forced. When forced, Sunshine may use a
+            legacy-capable fallback encoder for H.263+ streams without changing the encoder used for modern codecs.
+            @warning{H.263+ uses software encoding in Sunshine and may reduce host performance.}
+        </td>
+    </tr>
+    <tr>
+        <td>Default</td>
+        <td colspan="2">@code{}
+            0
+            @endcode</td>
+    </tr>
+    <tr>
+        <td>Example</td>
+        <td colspan="2">@code{}
+            h263p_mode = 2
+            @endcode</td>
+    </tr>
+    <tr>
+        <td rowspan="3">Choices</td>
+        <td>0</td>
+        <td>preserve modern codec automatic selection and keep H.263+ unadvertised</td>
+    </tr>
+    <tr>
+        <td>1</td>
+        <td>do not advertise support for H.263+</td>
+    </tr>
+    <tr>
+        <td>2</td>
+        <td>advertise support for H.263+ video</td>
+    </tr>
+</table>
+
 ### capture
 
 <table>

src/config.cpp

@@ -454,6 +454,8 @@ namespace config {
 
     0,  // hevc_mode
     0,  // av1_mode
+    0,  // mpeg2_mode
+    0,  // h263p_mode
 
     2,  // min_threads
     {
@@ -1101,6 +1103,8 @@ namespace config {
     int_f(vars, "qp", video.qp);
     int_between_f(vars, "hevc_mode", video.hevc_mode, {0, 3});
     int_between_f(vars, "av1_mode", video.av1_mode, {0, 3});
+    int_between_f(vars, "mpeg2_mode", video.mpeg2_mode, {0, 2});
+    int_between_f(vars, "h263p_mode", video.h263p_mode, {0, 2});
     int_f(vars, "min_threads", video.min_threads);
     string_f(vars, "sw_preset", video.sw.sw_preset);
     if (!video.sw.sw_preset.empty()) {

src/config.h

@@ -36,8 +36,10 @@ namespace config {
     // ffmpeg params
     int qp;  // higher == more compression and less quality
 
-    int hevc_mode;
-    int av1_mode;
+    int hevc_mode;  ///< HEVC codec advertisement mode.
+    int av1_mode;  ///< AV1 codec advertisement mode.
+    int mpeg2_mode;  ///< MPEG-2 codec advertisement mode.
+    int h263p_mode;  ///< H.263+ codec advertisement mode.
 
     int min_threads;  // Minimum number of threads/slices for CPU encoding
 

src/nvhttp.cpp

@@ -714,6 +714,12 @@ namespace nvhttp {
     if ((video::active_av1_mode == 4 || video::active_av1_mode == 5) && video::last_encoder_probe_supported_yuv444_for_codec[2]) {
       codec_mode_flags |= SCM_AV1_HIGH10_444;
     }
+    if (video::active_mpeg2_mode >= 2) {
+      codec_mode_flags |= SCM_MPEG2;
+    }
+    if (video::active_h263p_mode == 2) {
+      codec_mode_flags |= SCM_H263P;
+    }
     return codec_mode_flags;
   }
 

src/rtsp.cpp

@@ -815,6 +815,14 @@ namespace rtsp_stream {
       ss << "a=rtpmap:98 AV1/90000"sv << std::endl;
     }
 
+    if (video::active_mpeg2_mode >= 2) {
+      ss << "a=rtpmap:98 MPV/90000"sv << std::endl;
+    }
+
+    if (video::active_h263p_mode == 2) {
+      ss << "a=rtpmap:98 H263-1998/90000"sv << std::endl;
+    }
+
     if (!session.surround_params.empty()) {
       // If we have our own surround parameters, advertise them twice first
       ss << "a=fmtp:97 surround-params="sv << session.surround_params << std::endl;
@@ -1115,20 +1123,34 @@ namespace rtsp_stream {
       config.monitor.bitrate = (int) configuredBitrateKbps;
     }
 
-    if (config.monitor.videoFormat == 1 && video::active_hevc_mode == 1) {
+    if (config.monitor.videoFormat == video::format_hevc && video::active_hevc_mode == 1) {
       BOOST_LOG(warning) << "HEVC is disabled, yet the client requested HEVC"sv;
 
       respond(sock, session, &option, 400, "BAD REQUEST", req->sequenceNumber, {});
       return;
     }
 
-    if (config.monitor.videoFormat == 2 && video::active_av1_mode == 1) {
+    if (config.monitor.videoFormat == video::format_av1 && video::active_av1_mode == 1) {
       BOOST_LOG(warning) << "AV1 is disabled, yet the client requested AV1"sv;
 
       respond(sock, session, &option, 400, "BAD REQUEST", req->sequenceNumber, {});
       return;
     }
 
+    if (config.monitor.videoFormat == video::format_mpeg2 && video::active_mpeg2_mode < 2) {
+      BOOST_LOG(warning) << "MPEG-2 is disabled, yet the client requested MPEG-2"sv;
+
+      respond(sock, session, &option, 400, "BAD REQUEST", req->sequenceNumber, {});
+      return;
+    }
+
+    if (config.monitor.videoFormat == video::format_h263p && video::active_h263p_mode != 2) {
+      BOOST_LOG(warning) << "H.263+ is disabled, yet the client requested H.263+"sv;
+
+      respond(sock, session, &option, 400, "BAD REQUEST", req->sequenceNumber, {});
+      return;
+    }
+
     // Check that any required encryption is enabled
     auto encryption_mode = net::encryption_mode_for_address(sock.remote_endpoint().address());
     if (encryption_mode == config::ENCRYPTION_MODE_MANDATORY &&