Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/PulseAudio General issue if network on host disconnects. #112

Closed
GavinDarkglider opened this issue Mar 27, 2022 · 5 comments · Fixed by #190
Closed

Linux/PulseAudio General issue if network on host disconnects. #112

GavinDarkglider opened this issue Mar 27, 2022 · 5 comments · Fixed by #190
Labels
fixed This issue has been fixed and will be available in the next release.

Comments

@GavinDarkglider
Copy link

GavinDarkglider commented Mar 27, 2022

Describe the Bug

If using wifi on host, and host wifi disconnects while stream is in session, sunshine aborts, leaving the pulseaudio tunnels available, and set to default, so you have to manually change, or wait for pulseaudio to catch up. In the event of an error like this, sunshine should destroy these tunnels.

Also, side note, but while I am on the subject...... Honestly, it is more work even to get things like 5.1 working even though there are simple tunnels for them, the whole audio routing thing in pulseaudio might need looked at on both sides to fix this. lol.

Expected Behavior

On the event that sunshine crashes due to network error, or really anything that causes abort, we need to destroy all pulseaudi tunnels created by stream connect,

Additional Context

More of an improvement.

Sunshine Host Operating System and Version

Gentoo

Architecture

all

Sunshine Version

latest git at 4b658cd

GPU Type

Doesnt matter for this issue

GPU Model

Doesnt matter

GPU Driver/Mesa Version

Doesnt matter

Capture Method (Linux Only)

X11

@ReenigneArcher ReenigneArcher added the invalid:template-incomplete Template is not completed. label Mar 28, 2022
@github-actions
Copy link

👋 @GavinDarkglider, please edit your issue to complete the template with all the required info. Your issue will be automatically closed in 5 days if the template is not completed. Thanks.

@ReenigneArcher
Copy link
Member

Please update your issue, specifically this section: Sunshine Host Operating System and Version

@GavinDarkglider
Copy link
Author

GavinDarkglider commented Mar 28, 2022

Please update your issue, specifically this section: Sunshine Host Operating System and Version

Not sure why this matters at all, but I updated it. Pulseaudio, and audio tunnels arent removed on sunshine abort should be all that matters. This will effect all distros that use pulseaudio, and probably pipewire as well(That has other issues) and until sunshine includes code remove any existing sunshine pulseaudio tunnels if abort is called (Usually a network issue on server).

Also should mention that gentoo is a rolling self compiled distro, and doesnt follow standard distro release versions.

@ReenigneArcher ReenigneArcher added os:Linux:Arch OS is Arch Linux bug Something isn't working help wanted Extra attention is needed and removed invalid:template-incomplete Template is not completed. os:Linux:Arch OS is Arch Linux labels Mar 28, 2022
@HomerSp
Copy link
Contributor

HomerSp commented Apr 14, 2022

This should be fixed now, please give it a try if you're able to!

@ReenigneArcher ReenigneArcher added fixed This issue has been fixed and will be available in the next release. and removed help wanted Extra attention is needed labels Apr 14, 2022
@github-actions
Copy link

This issue has been fixed and will be available in the next release.

@ReenigneArcher ReenigneArcher mentioned this issue Jun 15, 2022
6 tasks
@ReenigneArcher ReenigneArcher removed the bug Something isn't working label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed This issue has been fixed and will be available in the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants