Installing or updating to latest release of ViGEmBus breaks client inputs in Sunshine #1822
Comments
ahk
changed the title
|
We're aware of it being EOL, and have been aware for probably about 2 months. Although it was originally not EOL from my understanding, but was just going to be a rebrand. Duplicate of https://github.com/LizardByte/Sunshine/discussions/1820 Duplicate of #1741 |
|
It's not a duplicate. The latest release of VigEmBus uninstalls itself and leaves sunshine unusable, immediately and forever, without further user interaction and knowledge. This situation is new as of 2-3 days ago and is what I'm reporting to you specifically. It seems the decision to EoL rather than rename was made very recently, and is going to affect all dependent projects due to this specific installer bug that will break existing installs until users realize what they need to do. |
|
This is just terminology that links these discussions together. |
|
@ahk just my 2 cents. On my personal setup, I've decided to stick to the [previous official release](ViGEmBus Setup 1.21.442) until the new project is publicly available. I would recommend that you downgrade ViGEmBus (purge current install and clean install older release) to that version, and simply tell the built-in updater to disable auto-updates for ViGEmBus. Not sure about ds4windows since I don't use that package at all for my DS4 controllers. |
|
@kurac338 Thank you so much. Since upgrading to the latest release of Sunshine last night, I can't figure out for the life of me why on all my devices the controller would work for 2 seconds before it seemingly loses focus and refuses to work again. Downgrading to 1.21.442 of the ViGEmBus driver worked flawlessly. |
|
I am experiencing this issue now, trying to get the Steam Deck to work. update: not sure if this was the issue. When running moonlight in game mode on steam deck, controls are borked and mouse is fixed in bottom right corner of screen. When running in desktop mode, controls work but I can't use moonlight hotkeys like Start+select+R1+L1 to exit stream. update 2: Turns out you have to jump through some hoops on steamdeck to figure it out. First, in game mode, go to your controller settings -> Edit layout -> Action Sets -> add an 'Always on Command' and select 'Touchscreen Native Support' in order to get the touchscreen working. Also in game mode, you can control the cursor etc by holding the steam button while you use the right touchpad. Or you can create additional action sets to switch between. If anyone's wondering how to pull up the moonshine overlay on steam deck, you have to bind command + subcommand to a radial menu for Ctrl + alt + shift + s. I couldn't get it to work if bound to a physical button. Hopes this helps anyone that ran into similar issues. |
|
also, on every update (and install), sunshine will attempt to install vigembus even if it's already installed |
Yes, that's intentional to ensure you get updated versions. |
Holy shit dude, thank you. I was pulling out my hair trying to figure out why my controller wasn't working. Works now after downgrading. |
|
FYI, in Sunshine nightly and future releases, Sunshine will no longer force an upgrade of vigembus if you already have a compatible version. Fixed in #1953 |
Is there an existing issue for this?
Is your issue described in the documentation?
Is your issue present in the nightly release?
Describe the Bug
For many (frequency unknown), if you use latest ViGEmBus then sunshine will be broken. It will not receive inputs from clients.
ViGEmBus will not successfully install either via first-time install or auto-update. Sunshine - which relies on ViGEmBus to work (right?) - will then not receive inputs from the streaming client. Sunshine (AFAICT) doesn't make this issue clear as I didn't receive a single notification that this issue was detected.
Here is some hopefully useful context so you don't have to dig around like I did:
ViGEmBus development has ceased. I was unaware of this, and did allow the latest update to auto-install.
This last update actually removed and then did not re-install ViGEmBus for me. It appears to be a bug with the updater tool they are using (although it sure seems a bit suspicious timing considering the context). See for example the section of the EoL post "How to fix 'Error: The filename, directory name, or volume label syntax is incorrect' update error?", or for more information the ds4windows summary of the update stating:
"In-place upgrade doesn't work for some reason; looks like you simply need to run the setup twice. Can't be bothered to figure out why."
So if you update ViGEmBus to latest through any means (it seems?) you will get a weird error which is both easy to miss and easy to ignore. You will think it's installed. You will try to use Sunshine, and it will run and let you start a session, but inputs will be nonfunctional. You will have no idea why, and finding out that you need to reinstall AGAIN was only made clear to me when I tried to run ds4windows and it prompted me that it wasn't installed. I thought that was odd and started researching a bit to get more context, which I've provided here.
Hopefully this is helpful to you, I have no idea what should be done about it. Also I'm really sorry this is hitting your project and I am incredibly appreciative of Sunshine. Thank you so much for your work. I'm also sad that this is the way ViGEmBus ends and was also incredibly appreciative of that work.
Let me know if you need anything else from me.
Expected Behavior
Using latest ViGEmBus should not break Sunshine inputs.
Additional Context
No response
Host Operating System
Windows
Operating System Version
Windows 11 Pro, Version 22H2, OS Build 22621.2428, Windows Feature Experience Pack 1000.22674.1000.0
Architecture
64 bit
Sunshine commit or version
0.21.0
Package
Windows - installer
GPU Type
AMD
GPU Model
RX 6800 XT
GPU Driver/Mesa Version
Adrenalin 23.11.1
Capture Method (Linux Only)
No response
Config
resolutions = [ 352x240, 480x360, 858x480, 1280x720, 1920x1080, 2560x1080, 3440x1440, 1920x1200, 3840x2160, 3840x1600, 1280x800 ] sunshine_name = wzrdboxApps
No response
Relevant log output
The text was updated successfully, but these errors were encountered: