Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on Windows PATH.. because Steam in not here.. autodected steam folder.. #2085

Closed
3 tasks done
ruthan opened this issue Feb 1, 2024 · 3 comments · Fixed by #2105
Closed
3 tasks done

Do not rely on Windows PATH.. because Steam in not here.. autodected steam folder.. #2085

ruthan opened this issue Feb 1, 2024 · 3 comments · Fixed by #2105
Labels
os:Windows OS is Windows

Comments

@ruthan
Copy link

ruthan commented Feb 1, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your issue described in the documentation?

  • I have read the documentation

Is your issue present in the nightly release?

  • This issue is present in the nightly release

Describe the Bug

Issues is described here:
https://www.reddit.com/r/MoonlightStreaming/comments/182afkg/moonlightsunshine_wont_launch_big_picture_mode/

Expected Behavior

Detect Steam.exe path from Windows registry. Hardcoded path its working.. Steam not adding anything to Windows Path by default.. so original command: steam steam://open/bigpicture could not work..
If its too hard for you, you can add some icon for user to navigate to Steam folder to WebGUI..

Additional Context

No response

Host Operating System

Docker

Operating System Version

Windows 10 22H2

Architecture

64 bit

Sunshine commit or version

0.21

Package

Windows - installer

GPU Type

Nvidia

GPU Model

Geforce 1070

GPU Driver/Mesa Version

Its does not matter, problem is elsewhere..

Capture Method (Linux Only)

Its does not matter, problem is elsewhere..

Config

audio_sink = 572b5350-8943-43ff-a3a1-851983754ecc

Apps

Its does not matter, problem is elsewhere..

Relevant log output

Its does not matter, problem is elsewhere..
@ReenigneArcher
Copy link
Member

We cater to the 99% of users who install Steam to the default location.

"PATH": "$(PATH);$(ProgramFiles(x86))\\Steam"

Feel free to open a PR to detect the steam location... although really Steam should be adding their directory to the PATH environment.

You can also just prefix the steam path if you don't use the default installation directory.

@ruthan

This comment was marked as off-topic.

@cgutman
Copy link
Collaborator

cgutman commented Feb 8, 2024

In the latest nightly build, the Steam shortcut defaults to using the steam:// URL directly, which is path-independent.

If you are upgrading from an older version, you can make the modification to your Steam shortcut in the Applications tab by removing the steam part from the steam steam://open/bigpicture command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os:Windows OS is Windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants