Fix build: llvm::Error needs to be moved for implicit conversion to Expected.

joker-eph · joker-eph · commit 5d33f7176b00 · 2024-03-07T15:19:27.000-08:00
I don't know why the premerge setup didn't fail on this, but many
builbots are broken right now.
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h b/llvm/include/llvm/ExecutionEngine/Orc/LLJIT.h
@@ -490,7 +490,7 @@ class LLJITBuilderSetters {
 
     if (impl().NotifyCreated)
       if (Error Err = impl().NotifyCreated(*J))
-        return Err;
+        return std::move(Err);
 
     return std::move(J);
   }

Original file line number	Diff line number	Diff line change
`@@ -490,7 +490,7 @@ class LLJITBuilderSetters {`
`490`	`490`
`491`	`491`	`if (impl().NotifyCreated)`
`492`	`492`	`if (Error Err = impl().NotifyCreated(*J))`
`493`		`- return Err;`
	`493`	`+ return std::move(Err);`
`494`	`494`
`495`	`495`	`return std::move(J);`
`496`	`496`	`}`