Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate-pull-request adds "Fixes #0" to the PR description if no issue is found (OSOE-745) #291

Open
Piedone opened this issue Nov 28, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Piedone
Copy link
Member

Piedone commented Nov 28, 2023

The validate-pull-request workflow, specifically Update-GitHubIssueAndPullRequest adds here a "Fixes #0" message to the PR's description if no matching issue is found. This might happen only if there are no issues at all (but the issues feature is enabled) because e.g. here this didn't happen.

Jira issue

@Piedone Piedone added the bug Something isn't working label Nov 28, 2023
@github-actions github-actions bot changed the title validate-pull-request adds "Fixes #0" to the PR description if no issue is found validate-pull-request adds "Fixes #0" to the PR description if no issue is found (OSOE-745) Nov 28, 2023
@BenedekFarkas
Copy link
Member

That's weird, I don't have a local repro in either PS or pwsh and in the "no issues at all" vs. "there are issues, but none match" cases, so the check on line 55 worked.

@Piedone
Copy link
Member Author

Piedone commented Nov 29, 2023

FYI under the internal issue I added some examples of this happening in a private repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants