Skip to content

Commit 2fa6a70

Browse files
committed
Merge remote-tracking branch 'origin/dev' into issue/OSOE-935
# Conflicts: # Lombiq.NodeJs.Extensions.Samples.NuGet/Lombiq.NodeJs.Extensions.Samples.NuGet.csproj
2 parents 4cdf023 + f411b67 commit 2fa6a70

File tree

4 files changed

+14
-4
lines changed

4 files changed

+14
-4
lines changed

Lombiq.NodeJs.Extensions.Samples.NuGet/Lombiq.NodeJs.Extensions.Samples.NuGet.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<ItemGroup>
2020
<!-- Adding Node.js Extensions as a PackageReference will result in inclusion of its .props and .targets files
2121
during Build. -->
22-
<PackageReference Include="Lombiq.NodeJs.Extensions" Version="2.1.2-alpha.0.osoe-935" />
22+
<PackageReference Include="Lombiq.NodeJs.Extensions" Version="2.1.2" />
2323
</ItemGroup>
2424

2525
</Project>

Lombiq.NodeJs.Extensions/Docs/SetupLinux.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Next we install NVM and Node.js in userspace.
1919
1. Install NVM for your user: `curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.1/install.sh | bash`
2020
2. Type `nvm`.
2121
- If you get _nvm: command not found_ error, reload your shell profile first (`source ~/.bashrc`) and try again.
22-
3. Install the latest Node.js with `nvm install node`.
22+
3. Install the latest LTS version of Node.js with `nvm install --lts`.
2323
- If you are going to use Gulp and you encounter problems with Node.js 16 or above, downgrade to Node.js 14 and make that the default: `nvm install 14 && nvm alias default 14.x.y` (replace `x` and `y` with the values from your shell output).
2424

2525
This is good enough for launching new apps, but e.g. MSBuild doesn't use a login shell. If you have a desktop environment (through a display manager), see if the following works on your system:

Lombiq.NodeJs.Extensions/build/NodeJsExtensionsNpmPackage.targets

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@
22

33
<!-- Try to enable pnpm via corepack, which is part of Node.js v16.9 and above. -->
44
<Target Name="EnablePnpm">
5-
<!-- Enable the latest version of pnpm@8 using an explicit version number, to avoid any surprise updates. -->
5+
<!-- Enable the latest version of pnpm included in the LTS version of Node.js using an explicit version number, to
6+
avoid any surprise updates. -->
7+
<!-- The hash for the PNPM version is only a workaround for https://github.com/nodejs/corepack/issues/612. It can be
8+
retrieved with `npm view [email protected]`. -->
69
<!-- Retry to work around sporadic errors when this is run by multiple threads at the same time. -->
710
<MSBuild
811
Projects="$(RetryCommand)"
9-
Properties="Command=corepack enable &amp;&amp; corepack prepare pnpm@8.14.3 --activate &amp;&amp; echo PNPM activated via corepack;NxVerbosity=$(NxVerbosity);WorkingDirectory=$(WorkingDirectory)" />
12+
Properties="Command=corepack enable &amp;&amp; corepack prepare pnpm@8.15.9+sha1.aa4bc353b5f59fe1f1df5d802ce049ddf7f3c60e --activate &amp;&amp; echo PNPM activated via corepack;NxVerbosity=$(NxVerbosity);WorkingDirectory=$(WorkingDirectory)" />
1013
</Target>
1114

1215
<!-- Adding Node.js Extensions as an npm package to the consuming project in order to be able to run the build, clean,

Readme.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,3 +134,10 @@ The `lint` script calls respective linting scripts for SCSS, JavaScript and Mark
134134
Bug reports, feature requests, comments, questions, code contributions and love letters are warmly welcome. You can send them to us via GitHub issues and pull requests. Please adhere to our [open-source guidelines](https://lombiq.com/open-source-guidelines) while doing so.
135135

136136
This project is developed by [Lombiq Technologies](https://lombiq.com/). Commercial-grade support is available through Lombiq.
137+
138+
### When a new Node.js LTS version is released
139+
140+
We always aim to support the latest LTS version of Node.js (what you can see [here](https://nodejs.org/en/about/previous-releases)). When a new LTS version is released, do the following:
141+
142+
- Update the PNPM version that `corepack` prepares to the one coming with the Node.js version in _NodeJsExtensionsNpmPackage.targets_ (look for `corepack prepare pnpm@`).
143+
- If any of the installation instructions needs to change, update the [Linux setup guide](Lombiq.NodeJs.Extensions/Docs/SetupLinux.md) as well as the [Windows setup guide](Lombiq.NodeJs.Extensions/Docs/SetupWindows.md) (these already instruct to install the latest LTS version).

0 commit comments

Comments
 (0)