Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datatables npm packages to supported versions, remove Assets workaround (OSOE-404) #120

Open
0liver opened this issue Oct 20, 2022 · 0 comments

Comments

@0liver
Copy link
Contributor

0liver commented Oct 20, 2022

This is a follow-up issue to OSOE-84.

Problem

Currently, Lombiq.DataTables uses patched versions of datatables.net base on 1.10.25 and datatables.net-bs4 based on 3.2.2.

The patches should long be available in newer releases, and we should return to using regular npm package dependencies to manage them.

Solution

  1. Add datatables.net and datatables.net-bs4 back to package.json dependencies.
  2. Update all dependencies to stable releases.
  3. Remove the Assets/UnmanagedNodeModules folder.
  4. Adjust the nodejsExtensions.assetsToCopy config object in package.json to copy the respective files from there instead of UnmanagedNodeModules.
  5. Also remove .github\actions\spelling\excludes.txt.

Jira issue

@github-actions github-actions bot changed the title Update datatables npm packages to supported versions, remove Assets workaround Update datatables npm packages to supported versions, remove Assets workaround (OSOE-404) Oct 20, 2022
0liver pushed a commit that referenced this issue Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant