Skip to content

Commit 8ae7836

Browse files
limingliu-amperetstuefe
authored andcommitted
8324781: runtime/Thread/TestAlwaysPreTouchStacks.java failed with Expected a higher ratio between stack committed and reserved
8325218: gc/parallel/TestAlwaysPreTouchBehavior.java fails Reviewed-by: stefank, jsjolen, stuefe
1 parent 2d0f4a8 commit 8ae7836

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

test/hotspot/jtreg/ProblemList.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ gc/epsilon/TestMemoryMXBeans.java 8206434 generic-all
7777
gc/g1/humongousObjects/objectGraphTest/TestObjectGraphAfterGC.java 8156755 generic-all
7878
gc/g1/logging/TestG1LoggingFailure.java 8169634 generic-all
7979
gc/g1/humongousObjects/TestHeapCounters.java 8178918 generic-all
80-
gc/parallel/TestAlwaysPreTouchBehavior.java 8325218 linux-all
8180
gc/TestAllocHumongousFragment.java#adaptive 8298781 generic-all
8281
gc/TestAllocHumongousFragment.java#aggressive 8298781 generic-all
8382
gc/TestAllocHumongousFragment.java#iu-aggressive 8298781 generic-all
@@ -102,7 +101,6 @@ runtime/StackGuardPages/TestStackGuardPagesNative.java 8303612 linux-all
102101
runtime/ErrorHandling/TestDwarf.java#checkDecoder 8305489 linux-all
103102
runtime/ErrorHandling/MachCodeFramesInErrorFile.java 8313315 linux-ppc64le
104103
runtime/cds/appcds/customLoader/HelloCustom_JFR.java 8241075 linux-all,windows-x64
105-
runtime/Thread/TestAlwaysPreTouchStacks.java 8324781 linux-all
106104

107105
applications/jcstress/copy.java 8229852 linux-all
108106

test/hotspot/jtreg/gc/parallel/TestAlwaysPreTouchBehavior.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
* @requires os.family == "linux"
3232
* @requires os.maxMemory > 2G
3333
* @library /test/lib
34-
* @run main/othervm -Xmx1g -Xms1g -XX:+UseParallelGC -XX:+AlwaysPreTouch gc.parallel.TestAlwaysPreTouchBehavior
34+
* @run main/othervm -Xmx1g -Xms1g -XX:+UseParallelGC -XX:+AlwaysPreTouch -XX:+UnlockDiagnosticVMOptions -XX:-UseMadvPopulateWrite gc.parallel.TestAlwaysPreTouchBehavior
3535
*/
3636
import java.lang.management.ManagementFactory;
3737
import java.lang.management.ThreadInfo;
@@ -77,4 +77,3 @@ public static void main(String [] args) {
7777
Asserts.assertGreaterThanOrEqual(rss, committedMemory, "RSS of this process(" + rss + "kb) should be bigger than or equal to committed heap mem(" + committedMemory + "kb)");
7878
}
7979
}
80-

test/hotspot/jtreg/runtime/Thread/TestAlwaysPreTouchStacks.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
import java.io.IOException;
2929
import java.util.ArrayList;
30+
import java.util.Collections;
3031
import java.util.regex.Matcher;
3132
import java.util.regex.Pattern;
3233
import java.util.concurrent.CyclicBarrier;
@@ -89,14 +90,17 @@ public static void main(String[] args) throws Exception {
8990
// should show up with fully - or almost fully - committed thread stacks.
9091

9192
} else {
92-
93-
ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(
93+
ArrayList<String> vmArgs = new ArrayList<>();
94+
Collections.addAll(vmArgs,
9495
"-XX:+UnlockDiagnosticVMOptions",
9596
"-Xmx100M",
9697
"-XX:+AlwaysPreTouchStacks",
97-
"-XX:NativeMemoryTracking=summary", "-XX:+PrintNMTStatistics",
98-
"TestAlwaysPreTouchStacks",
99-
"test");
98+
"-XX:NativeMemoryTracking=summary", "-XX:+PrintNMTStatistics");
99+
if (System.getProperty("os.name").contains("Linux")) {
100+
vmArgs.add("-XX:-UseMadvPopulateWrite");
101+
}
102+
Collections.addAll(vmArgs, "TestAlwaysPreTouchStacks", "test");
103+
ProcessBuilder pb = ProcessTools.createLimitedTestJavaProcessBuilder(vmArgs);
100104
OutputAnalyzer output = new OutputAnalyzer(pb.start());
101105
output.reportDiagnosticSummary();
102106

0 commit comments

Comments
 (0)