Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkingSpecification removed, why? #28

Open
davidonzo opened this issue Dec 15, 2017 · 3 comments
Open

MarkingSpecification removed, why? #28

davidonzo opened this issue Dec 15, 2017 · 3 comments

Comments

@davidonzo
Copy link
Contributor

# Remove any "marking" sections because the US-Cert is evil

# Remove any "marking" sections because the US-Cert is evil
log.debug("Removing Marking elements...")
for element in stixXml.findall(".//{http://data-marking.mitre.org/Marking-1}Marking"):
element.getparent().remove(element)

The script remove any marking specification. Why?

I'm working on a "misp_taxii_hook" for the opentaxii's misp implementation that is able to parse the marking structure of the stix package and create the tlp tags as needed.

In my local installation I just tried to edit the file, removing the quoted lines. And it seems to work fine.
The stix parsing works as before, bet I have marking specification to parse.

Can you consider to remove the quoted lines.

@davidonzo
Copy link
Contributor Author

Here is the patch for your evaluation

davidonzo@2b10ea2

@FloatingGhost
Copy link
Member

If I remember rightly the US-Cert's marking would crash the entire converter, hence why I purge it

@davidonzo
Copy link
Contributor Author

Ok, so I can continue to test.
ATM all seems to work fine, no error reported, but of course, I need a bit more time.

I'll update you ASAP.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants