Skip to content

Typo in MISPGalaxyCluster.from_dict prevents field blocklist from being checked #1458

Description

@mspinka-r7

The missing comma between "distribution" and "sharing_group_id" means these two string literals get concatenated into a single string:

>>> blocked_fields = ["distribution" "sharing_group_id"]
>>> print(blocked_fields)
['distributionsharing_group_id']

blocked_fields = ["distribution" "sharing_group_id"]

No idea how often this can cause an issue, I just noticed it while looking at the source code when working with PyMISP.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions