Skip to content

Commit 0cfe273

Browse files
authoredMar 18, 2025··
newsfeed: add specific ignoreOlderThan value (override) per feed (#3742)
fixes #3360 superseeds #3429 had to open a new PR because getting `permission denied` when trying to push to the old one.
1 parent 51d11bf commit 0cfe273

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed
 

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ planned for 2025-04-01
1919
- Add Arabic (#3719) and Esperanto translation.
2020
- Mark option `secondsColor` as deprecated in clock module.
2121
- Add Greek translation to Alerts module.
22+
- [newsfeed] Add specific ignoreOlderThan value (override) per feed (#3360)
2223

2324
### Changed
2425

‎modules/default/newsfeed/newsfeed.js

+13-1
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,18 @@ Module.register("newsfeed", {
177177
}
178178
},
179179

180+
/**
181+
* Gets a feed property by name
182+
* @param {object} feed A feed object.
183+
* @param {string} property The name of the property.
184+
*/
185+
getFeedProperty (feed, property) {
186+
let res = this.config[property];
187+
const f = this.config.feeds.find((feedItem) => feedItem.url === feed);
188+
if (f && f[property]) res = f[property];
189+
return res;
190+
},
191+
180192
/**
181193
* Generate an ordered list of items for this configured module.
182194
* @param {object} feeds An object with feeds returned by the node helper.
@@ -188,7 +200,7 @@ Module.register("newsfeed", {
188200
if (this.subscribedToFeed(feed)) {
189201
for (let item of feedItems) {
190202
item.sourceTitle = this.titleForFeed(feed);
191-
if (!(this.config.ignoreOldItems && Date.now() - new Date(item.pubdate) > this.config.ignoreOlderThan)) {
203+
if (!(this.getFeedProperty(feed, "ignoreOldItems") && Date.now() - new Date(item.pubdate) > this.getFeedProperty(feed, "ignoreOlderThan"))) {
192204
newsItems.push(item);
193205
}
194206
}

0 commit comments

Comments
 (0)
Please sign in to comment.