make colorrange_scaled computation safe for inverting / sort-order-breaking scales
#4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
asinghvi17
changed the title
apply_scale safe for inverting / sort-order-breaking scalescolorrange_scaled computation safe for inverting / sort-order-breaking scales
Benchmark ResultsSHA: 6f282491b65c8abc757f02f6faa85442fdc1f432 Warning These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.
|
ffreyer
reviewed
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4883
Wraps calls to
apply_scale(scale, colorrange)inextremaso that the computed colorrange is robust to e.g.colorscale = -.Not sure this needs a reference test given it's a bug on the Makie end of things.
Type of change
Delete options that do not apply:
Checklist