[WIP] Upgrade gettext_i18n_rails_js for escape fix and lazy loaded parser #23580
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.0.0 includes a bug fix we reported in: https://www.github.com/webhippie/gettext_i18n_rails_js/issues/42 Compare: webhippie/gettext_i18n_rails_js@v1.4.0...v2.0.0 Note, this also pulls in a new po_to_json gem. 2.1.0 includes a lazy load parser fix from me, so I think that's safe to move to Compare: webhippie/gettext_i18n_rails_js@v2.0.0...v2.1.0 I ran it locally with 1.4.0 and and 2.1.0 and the json files are identical.
|
Reminder that we have a po to json patch in our patches (you don't think we ever upstreamed it but we should). Can you verify that patch still is correct? https://github.com/ManageIQ/manageiq/blob/master/lib%2Ftasks%2Fpo_to_json_override.rb |
Good point, marking as wip so I can verify the patch. |
jrafanie
changed the title
Reading back I don't know why I wrote "you" I meant "I" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #23566
2.0.0 includes a bug fix we reported in:
https://www.github.com/webhippie/gettext_i18n_rails_js/issues/42
Compare: webhippie/gettext_i18n_rails_js@v1.4.0...v2.0.0
Note, this also pulls in a new po_to_json gem.
2.1.0 includes a lazy load parser fix from me, so I think that's safe to move to.
Compare: webhippie/gettext_i18n_rails_js@v2.0.0...v2.1.0
I ran it locally with 1.4.0 and and 2.1.0 and the json files are identical.
NOTE: bundle exec rake locale:update_all produces much different results with 1.4.0, 2.0.0, 2.1.0, and 2.2.0 versions so we'll need to handle both upgrades together.
See revert in #23584 and some issues found in #23583