Fix PointData::setIndexOfVariant accidentally doing pass-by-value (#495)

N-Dekker · web-flow · commit b83c803b46d7 · 2024-02-08T11:24:12.000+01:00
The first parameter of the private member function `PointData::setIndexOfVariant` should be passed by reference. Before this commit, it did pass-by-value, causing calls to `PointData::setElementTypeSpecifier` to have no effect at all. The bug was introduced with pull request #454 commit 55f50a9 "Replace private `PointData::VectorHolder` class with `std::variant` (merged on 5 February 2024) and reported to me by Jeroen Eggermont.
diff --git a/HDPS/src/plugins/PointData/src/PointData.h b/HDPS/src/plugins/PointData/src/PointData.h
@@ -78,7 +78,7 @@ class POINTDATA_EXPORT PointData : public mv::plugin::RawData
     // Inspired by `expand_type` from kmbeutel at
     // https://www.reddit.com/r/cpp/comments/f8cbzs/creating_stdvariant_based_on_index_at_runtime/?rdt=52905
     template <typename... Alternatives>
-    static void setIndexOfVariant(std::variant<Alternatives...> var, std::size_t index)
+    static void setIndexOfVariant(std::variant<Alternatives...>& var, std::size_t index)
     {
         if (index != var.index())
         {

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ class POINTDATA_EXPORT PointData : public mv::plugin::RawData`
`78`	`78`	// Inspired by `expand_type` from kmbeutel at
`79`	`79`	`// https://www.reddit.com/r/cpp/comments/f8cbzs/creating_stdvariant_based_on_index_at_runtime/?rdt=52905`
`80`	`80`	`template <typename... Alternatives>`
`81`		`- static void setIndexOfVariant(std::variant<Alternatives...> var, std::size_t index)`
	`81`	`+ static void setIndexOfVariant(std::variant<Alternatives...>& var, std::size_t index)`
`82`	`82`	`{`
`83`	`83`	`if (index != var.index())`
`84`	`84`	`{`