Reverting two changes that triggers an error in the automatic testing.

Further work on type hinting.

Avoid forwarding positional arguments from Arrow to Line in the constructor.

Revert "Avoid forwarding positional arguments from Arrow to Line in the constructor."

This reverts commit 80ae857.

Removed several type ignore statements and addressed comments from JasonGrace2282

Revert "Activate mypy check of mobject.geometry.*"

This reverts commit d477c9a.

Revert "Removed several type ignore statements and addressed comments from JasonGrace2282"

This reverts commit 07bbe3f.

Added type annotations to zoomed_scene.py

Error count: 308 -> 303

Adding type annotations to all methods in vector_space_scene.py

Error count: 303 -> 272

Get rid of no-untyped-call errors from my in the vector_space_scene.py file

Error count: 272 -> 343

Handle type issues related to ManimColor in vector_space_scene.py

Handle var-annotated issues in vector_space_scene.py

Error count: 332 -> 330

Handling has-type type errors in vector_space_scene.py

Error count: 330 -> 285

Handled name-defined type issues in vector_space_scene.py

Error count: 285 -> 282

Address type issue with calling an untyped method.

Error count: 282 -> 281

Fix some typing issues in transform_mathcing_parts.py

Change stroke_width to float in vector_space_scene.py

Handled a few type errors.

Error count: 267

Handled several typing issues in three_d_scene.py

Error count: 267 -> 248

Dealing with type errors in scene_file_writer.py

Error count: 248 -> 216

Ensured that all methods in scene.py have type declarations.

Error count: 216 -> 225

Handle type issues related to interactivity by asserting that the camera is the OpenGLCamera

Error count: 225 -> 182

Handle type issues in scene.py

Error count: 182 -> 167

Asserting that the renderer or camera is of the proper type to use certain methods.

This is mainly related to interactive elements and the 3D camera used in the ThreeDScene

Error count: 167 -> 143

Avoid cyclic import of dependencies

Error count: 143 -> 143

Handling no-untyped-call type errors in manim/scene/scene.py

Error count: 143 -> 131

Handling assignment type errors in manim/scene/*.py

Error count: 131 -> 121

Handling arg-type type errors in manim/scene/*.py

Error count: 121 -> 116

Handling arg-type type errors in manim/scene/*.py

Error count: 116 -> 112

Fixing various type errors

Error count: 112 -> 102

Fixing various type errors

Error count: 102 -> 97

Fixing various type errors

Error count: 97 -> 90

Some aggressive changes to silence a significant number of type errors.

Error count: 90 -> 66

Commented out an import (IPython) that makes the CI tests fail.

Fix various type errors.

More type annotations.

Code cleanup.

Remove the property mobject_updater_lists of the Scene class as it is not used anywhere.

Handle import-untyped typing issues.

Author: henrikmidtiby

manim/animation/transform.py

@@ -49,6 +49,8 @@
 from ..utils.rate_functions import smooth, squish_rate_func
 
 if TYPE_CHECKING:
+    from typing import Any
+
     from ..scene.scene import Scene
 
 
@@ -516,7 +518,7 @@ def construct(self):
 
     def __init__(
         self,
-        function: types.MethodType,
+        function: Callable,
         mobject: Mobject,
         run_time: float = DEFAULT_POINTWISE_FUNCTION_RUN_TIME,
         **kwargs,
@@ -615,7 +617,9 @@ def __init__(self, mobject: Mobject, **kwargs) -> None:
 
 
 class ApplyFunction(Transform):
-    def __init__(self, function: types.MethodType, mobject: Mobject, **kwargs) -> None:
+    def __init__(
+        self, function: Callable[[Any], Any], mobject: Mobject, **kwargs: Any
+    ) -> None:
         self.function = function
         super().__init__(mobject, **kwargs)
 

manim/animation/transform_matching_parts.py

@@ -20,6 +20,8 @@
 from .transform import FadeTransformPieces, Transform
 
 if TYPE_CHECKING:
+    from typing import Any
+
     from ..scene.scene import Scene
 
 
@@ -74,7 +76,7 @@ def __init__(
         transform_mismatches: bool = False,
         fade_transform_mismatches: bool = False,
         key_map: dict | None = None,
-        **kwargs,
+        **kwargs: Any,
     ):
         if isinstance(mobject, OpenGLVMobject):
             group_type = OpenGLVGroup
@@ -162,11 +164,11 @@ def clean_up_from_scene(self, scene: Scene) -> None:
         scene.add(self.to_add)
 
     @staticmethod
-    def get_mobject_parts(mobject: Mobject):
+    def get_mobject_parts(mobject: Mobject) -> None:
         raise NotImplementedError("To be implemented in subclass.")
 
     @staticmethod
-    def get_mobject_key(mobject: Mobject):
+    def get_mobject_key(mobject: Mobject) -> None:
         raise NotImplementedError("To be implemented in subclass.")
 
 
@@ -206,7 +208,7 @@ def __init__(
         transform_mismatches: bool = False,
         fade_transform_mismatches: bool = False,
         key_map: dict | None = None,
-        **kwargs,
+        **kwargs: Any,
     ):
         super().__init__(
             mobject,
@@ -269,7 +271,7 @@ def __init__(
         transform_mismatches: bool = False,
         fade_transform_mismatches: bool = False,
         key_map: dict | None = None,
-        **kwargs,
+        **kwargs: Any,
     ):
         super().__init__(
             mobject,

manim/camera/camera.py

@@ -274,7 +274,9 @@ def init_background(self):
             )
             self.background[:, :] = background_rgba
 
-    def get_image(self, pixel_array: np.ndarray | list | tuple | None = None):
+    def get_image(
+        self, pixel_array: np.ndarray | list | tuple | None = None
+    ) -> Image.Image:
         """Returns an image from the passed
         pixel array, or from the current frame
         if the passed pixel array is none.

manim/camera/moving_camera.py

@@ -10,6 +10,8 @@
 
 __all__ = ["MovingCamera"]
 
+from typing import TYPE_CHECKING
+
 import numpy as np
 
 from .. import config
@@ -19,6 +21,11 @@
 from ..mobject.mobject import Mobject
 from ..utils.color import WHITE
 
+if TYPE_CHECKING:
+    from typing import Any
+
+    from manim.utils.color import ParsableManimColor
+
 
 class MovingCamera(Camera):
     """
@@ -32,12 +39,12 @@ class MovingCamera(Camera):
 
     def __init__(
         self,
-        frame=None,
-        fixed_dimension=0,  # width
-        default_frame_stroke_color=WHITE,
-        default_frame_stroke_width=0,
-        **kwargs,
-    ):
+        frame: ScreenRectangle | None = None,
+        fixed_dimension: Any = 0,  # width
+        default_frame_stroke_color: ParsableManimColor = WHITE,
+        default_frame_stroke_width: float = 0,
+        **kwargs: Any,
+    ) -> None:
         """
         Frame is a Mobject, (should almost certainly be a rectangle)
         determining which region of space the camera displays
@@ -158,7 +165,7 @@ def cache_cairo_context(self, pixel_array, ctx):
     #         self.frame_shape = (self.frame.height, width)
     #     self.resize_frame_shape(fixed_dimension=self.fixed_dimension)
 
-    def get_mobjects_indicating_movement(self):
+    def get_mobjects_indicating_movement(self) -> list[ScreenRectangle]:
         """
         Returns all mobjects whose movement implies that the camera
         should think of all other mobjects on the screen as moving

manim/camera/multi_camera.py

@@ -5,7 +5,7 @@
 __all__ = ["MultiCamera"]
 
 
-from manim.mobject.types.image_mobject import ImageMobject
+from manim.mobject.types.image_mobject import ImageMobject, ImageMobjectFromCamera
 
 from ..camera.moving_camera import MovingCamera
 from ..utils.iterables import list_difference_update
@@ -38,7 +38,9 @@ def __init__(
         )
         super().__init__(**kwargs)
 
-    def add_image_mobject_from_camera(self, image_mobject_from_camera: ImageMobject):
+    def add_image_mobject_from_camera(
+        self, image_mobject_from_camera: ImageMobjectFromCamera
+    ):
         """Adds an ImageMobject that's been obtained from the camera
         into the list ``self.image_mobject_from_cameras``
 

manim/camera/three_d_camera.py

@@ -84,7 +84,7 @@ def capture_mobjects(self, mobjects, **kwargs):
         self.reset_rotation_matrix()
         super().capture_mobjects(mobjects, **kwargs)
 
-    def get_value_trackers(self):
+    def get_value_trackers(self) -> list[ValueTracker]:
         """A list of :class:`ValueTrackers <.ValueTracker>` of phi, theta, focal_distance,
         gamma and zoom.
 

manim/gui/gui.py

@@ -11,6 +11,8 @@
 
 
 from .. import __version__, config
+from ..renderer.cairo_renderer import CairoRenderer
+from ..renderer.opengl_renderer import OpenGLRenderer
 from ..utils.module_ops import scene_classes_from_file
 
 __all__ = ["configure_pygui"]
@@ -20,7 +22,9 @@
     window = dpg.generate_uuid()
 
 
-def configure_pygui(renderer, widgets, update=True):
+def configure_pygui(
+    renderer: CairoRenderer | OpenGLRenderer, widgets, update: bool = True
+) -> None:
     if not dearpygui_imported:
         raise RuntimeError("Attempted to use DearPyGUI when it isn't imported.")
     if update:

manim/mobject/geometry/arc.py

@@ -284,15 +284,15 @@ def get_last_handle(self) -> Point3D:
 
     def get_end(self) -> Point3D:
         if self.has_tip():
-            return self.tip.get_start()  # type: ignore[return-value]
+            return self.tip.get_start()
         else:
-            return super().get_end()  # type: ignore[return-value]
+            return super().get_end()
 
     def get_start(self) -> Point3D:
         if self.has_start_tip():
-            return self.start_tip.get_start()  # type: ignore[return-value]
+            return self.start_tip.get_start()
         else:
-            return super().get_start()  # type: ignore[return-value]
+            return super().get_start()
 
     def get_length(self) -> float:
         start, end = self.get_start_and_end()

manim/mobject/geometry/boolean_ops.py

@@ -5,7 +5,7 @@
 from typing import TYPE_CHECKING
 
 import numpy as np
-from pathops import Path as SkiaPath  # type: ignore[import-untyped]
+from pathops import Path as SkiaPath
 from pathops import PathVerb, difference, intersection, union, xor
 
 from manim import config
@@ -106,7 +106,7 @@ def _convert_vmobject_to_skia_path(self, vmobject: VMobject) -> SkiaPath:
                 for _p0, p1, p2, p3 in quads:
                     path.cubicTo(*p1[:2], *p2[:2], *p3[:2])
 
-                if vmobject.consider_points_equals_2d(subpath[0], subpath[-1]):  # type: ignore[arg-type]
+                if vmobject.consider_points_equals_2d(subpath[0], subpath[-1]):
                     path.close()
 
         return path

manim/mobject/geometry/line.py

@@ -169,9 +169,9 @@ def _pointify(
         if isinstance(mob_or_point, (Mobject, OpenGLMobject)):
             mob = mob_or_point
             if direction is None:
-                return mob.get_center()  # type: ignore[return-value]
+                return mob.get_center()
             else:
-                return mob.get_boundary_point(direction)  # type: ignore[return-value]
+                return mob.get_boundary_point(direction)
         return np.array(mob_or_point)
 
     def set_path_arc(self, new_value: float) -> None:
@@ -333,7 +333,7 @@ def get_start(self) -> Point3D:
             array([-1.,  0.,  0.])
         """
         if len(self.submobjects) > 0:
-            return self.submobjects[0].get_start()  # type: ignore[return-value]
+            return self.submobjects[0].get_start()
         else:
             return super().get_start()
 
@@ -348,7 +348,7 @@ def get_end(self) -> Point3D:
             array([1., 0., 0.])
         """
         if len(self.submobjects) > 0:
-            return self.submobjects[-1].get_end()  # type: ignore[return-value]
+            return self.submobjects[-1].get_end()
         else:
             return super().get_end()