scale stroke_width if font_size is too small or too big

Author: irvanalhaq9

manim/animation/creation.py

@@ -94,6 +94,7 @@ def construct(self):
 from ..animation.animation import Animation
 from ..animation.composition import Succession
 from ..mobject.mobject import Group, Mobject
+from ..mobject.svg.svg_mobject import SVGMobject
 from ..mobject.types.vectorized_mobject import VMobject
 from ..utils.bezier import integer_interpolate
 from ..utils.rate_functions import double_smooth, linear
@@ -293,9 +294,8 @@ def interpolate_submobject(
 
 
 class Write(DrawBorderThenFill):
-    """Simulate hand-writing a text-based mobject, such as :class:`~.Text`,
-    :class:`~.MarkupText`, :class:`~.Tex`, :class:`~.MathTex`,
-    or :class:`~.VMobject` in general.
+    """Simulate hand-writing a text-based mobject, such as :class:`~.Text`
+    and :class:`~.Tex`, or simulate hand-drawing a :class:`~.VMobject`.
 
     Parameters
     ----------
@@ -344,7 +344,6 @@ def __init__(
         reverse: bool = False,
         **kwargs,
     ) -> None:
-        self._typecheck_input(vmobject)
         run_time: float | None = kwargs.pop("run_time", None)
         lag_ratio: float | None = kwargs.pop("lag_ratio", None)
         run_time, lag_ratio = self._set_default_config_from_length(
@@ -387,17 +386,14 @@ def _adjust_stroke_width_for_text(
     ) -> float:
         if stroke_width is not None:
             return stroke_width
-        if vmobject.height != 0:
-            # if the height is zero, accessing font_size causes ZeroDivisionError
-            font_size = getattr(vmobject, "font_size", DEFAULT_FONT_SIZE)
-            if font_size < 20 or font_size > 6 * DEFAULT_FONT_SIZE:
-                # Assuming the user is using MovingCameraScene and performing a zoom-in or zoom-out
-                return (
-                    (font_size / DEFAULT_FONT_SIZE)
-                    * DEFAULT_STROKE_WIDTH
-                    * scale_factor
-                )
-        return 2  # default in DrawBorderThenFill
+        if not isinstance(vmobject, SVGMobject) or vmobject.height == 0:
+            return 2
+        font_size = getattr(vmobject, "font_size", DEFAULT_FONT_SIZE)
+        if font_size < 20 or font_size > 6 * DEFAULT_FONT_SIZE:
+            # adjust stroke_width if font_size is too small or too big
+            return (font_size / DEFAULT_FONT_SIZE) * DEFAULT_STROKE_WIDTH * scale_factor
+        else:
+            return 2
 
     def reverse_submobjects(self) -> None:
         self.mobject.invert(recursive=True)