Added tests

Author: MarieRoald

tests/test_decomposition.py

@@ -1958,3 +1958,41 @@ def test_regs_list_is_not_modified(random_ragged_cmf, regs):
     )
 
     assert regs == regs_unmodified
+
+
+
+@pytest.mark.parametrize("constant_feasibility_penalty", ["", "AB", "C"])
+def test_constant_feasibility_penalty_fails_with_invalid(random_ragged_cmf, constant_feasibility_penalty):
+
+    cmf, shapes, rank = random_ragged_cmf
+    matrices = cmf.to_matrices()
+
+    # Check that we get correct output when none of the conditions are met
+    with pytest.raises(ValueError):
+        decomposition.cmf_aoadmm(
+            matrices,
+            rank,
+            n_iter_max=0,
+            return_errors=True,
+            verbose=False,
+            non_negative=True,
+            parafac2=True,
+            constant_feasibility_penalty=constant_feasibility_penalty
+        )
+
+
+@pytest.mark.parametrize("constant_feasibility_penalty", ["A", "B", True, False, None])
+def test_constant_feasibility_penalty_works_with_valid(random_ragged_cmf, constant_feasibility_penalty):
+    cmf, shapes, rank = random_ragged_cmf
+    matrices = cmf.to_matrices()
+
+    decomposition.cmf_aoadmm(
+        matrices,
+        rank,
+        n_iter_max=0,
+        return_errors=True,
+        verbose=False,
+        non_negative=True,
+        parafac2=True,
+        constant_feasibility_penalty=constant_feasibility_penalty
+    )

tests/test_utils.py

@@ -1,5 +1,6 @@
 # MIT License: Copyright (c) 2022, Marie Roald.
 # See the LICENSE file in the root directory for full license text.
+from unittest.mock import patch
 
 import numpy as np
 import pytest
@@ -62,6 +63,14 @@ def test_get_svd(rng, svd):
     assert allclose(U1TU2 * Vh1Vh2T, np.eye(U1TU2.shape[0]))
 
 
+def test_get_svd_works_with_old_tensorly():
+    svds = {"TEST": "SVD"}
+    with patch("matcouply._utils.tl.SVD_FUNS", svds) as mock:
+        svd = utils.get_svd("TEST")
+
+    assert svd == svds["TEST"]
+
+
 def test_get_svd_fails_with_invalid_svd_name():
     with pytest.raises(ValueError):
         utils.get_svd("THIS_IS_NOT_A_VALID_SVD")