Skip to content

Commit 04c45dd

Browse files
committed
- Updated changelog
- Fixed handling of IDs greater than 32bits for TwitterProvider - renamed test-kit app name
1 parent b4491ad commit 04c45dd

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

ChangeLog

+7
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11
master -
2+
- Fixed handling of IDs greater than 32bits for TwitterProvider
3+
- Prevent errors caused by missing email in FacebookProvider (thanks @chrisbeach)
4+
- Handle onSignUpGoTo configuration when signupSkipLogin is enabled (thanks @paiou)
5+
- LinkedInOAuth2Provider: retrieve email address and add sample configuration (thanks @paiou)
6+
- Improve logging behaviour (thanks @jeantil)
7+
- Add test helpers for unit and integration testing of securesocial controllers (thanks @jeantil)
8+
- Added Finnish translation (thanks @hannikkala)
29
- Fixed error in Hebrew message file: was utf-8, now utf-8 without bom (thanks @katrinsharp)
310
- Added Swedish translation (thanks @ricn)
411
- Added Japanese translation (thanks @orih)

module-code/app/securesocial/core/providers/TwitterProvider.scala

+3-3
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@ class TwitterProvider(application: Application) extends OAuth1Provider(applicati
3939
try {
4040
val response = awaitResult(call)
4141
val me = response.json
42-
val userId = (me \ Id).as[Int]
42+
val userId = (me \ Id).as[String]
4343
val name = (me \ Name).as[String]
4444
val profileImage = (me \ ProfileImage).asOpt[String]
45-
user.copy(identityId = IdentityId(userId.toString, id), fullName = name, avatarUrl = profileImage)
45+
user.copy(identityId = IdentityId(userId, id), fullName = name, avatarUrl = profileImage)
4646

4747
} catch {
4848
case e: Exception => {
@@ -56,7 +56,7 @@ class TwitterProvider(application: Application) extends OAuth1Provider(applicati
5656
object TwitterProvider {
5757
val VerifyCredentials = "https://api.twitter.com/1.1/account/verify_credentials.json"
5858
val Twitter = "twitter"
59-
val Id = "id"
59+
val Id = "id_str"
6060
val Name = "name"
6161
val ProfileImage = "profile_image_url_https"
6262
}

samples/scala/demo/project/Build.scala

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ object ApplicationBuild extends Build {
88
val appVersion = "1.0"
99

1010
val appDependencies = Seq(
11-
"ws.securesocial" %% "securesocial" % "master-SNAPSHOT",
12-
"ws.securesocial" %% "ss-testkit" % "master-SNAPSHOT" % "test"
11+
"ws.securesocial" %% "securesocial" % "master-SNAPSHOT",
12+
"ws.securesocial" %% "securesocial-testkit" % "master-SNAPSHOT" % "test"
1313
)
1414
val main = play.Project(appName, appVersion, appDependencies).settings(
1515
resolvers += Resolver.sonatypeRepo("snapshots")

test-kit/project/Build.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Keys._
33

44
object ApplicationBuild extends Build {
55

6-
val appName = "ss-testkit"
6+
val appName = "securesocial-testkit"
77
val appVersion = "master-SNAPSHOT"
88
val appOrganization = "ws.securesocial"
99
val dependencies = Seq(

0 commit comments

Comments
 (0)