Skip to content

Commit 6088a76

Browse files
committed
ci: update to using M1 macos for builds and minimum deployment target to 10.15
1 parent 7ba545b commit 6088a76

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.gitlab-ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,8 @@ build:macos:
209209
stage: build
210210
needs: []
211211
tags:
212-
- shared-macos-amd64
213-
image: macos-11-xcode-12
212+
- saas-macos-medium-m1
213+
image: macos-12-xcode-14
214214
variables:
215215
# Location node-gyp installed headers and static libraries
216216
npm_config_devdir: "${CI_PROJECT_DIR}/tmp/node-gyp"

binding.gyp

+3-3
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
},
5353
'VCLinkerTool': {
5454
'AdditionalDependencies': [
55-
# SDK import libs
55+
# Windows SDK libs required for rocksdb
5656
'Shlwapi.lib',
5757
'rpcrt4.lib'
5858
]
@@ -68,8 +68,8 @@
6868
'cflags+': [ '-fvisibility=hidden' ],
6969
'cflags_cc+': [ '-fvisibility=hidden' ],
7070
'xcode_settings': {
71-
# Minimum mac osx target version (matches node v16.14.2)
72-
'MACOSX_DEPLOYMENT_TARGET': '10.13',
71+
# Minimum mac osx target version (matches node v18.15.0 common.gypi)
72+
'MACOSX_DEPLOYMENT_TARGET': '10.15',
7373
# This is also needed to prevent exporting of symbols
7474
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES',
7575
'OTHER_CFLAGS': [

0 commit comments

Comments
 (0)