small/medium shield F_SHIELD flag! (#8727)

Small/Medium Shield are missing F_SHIELD

Author: exeea

megamek/src/megamek/common/equipment/MiscType.java

@@ -3885,7 +3885,7 @@ public static MiscType createISSmallShield() {
         misc.tonnage = 2;
         misc.criticalSlots = 3;
         misc.cost = 50000;
-        misc.flags = misc.flags.or(F_MEK_EQUIPMENT, MiscTypeFlag.S_SHIELD_SMALL);
+        misc.flags = misc.flags.or(F_SHIELD, F_MEK_EQUIPMENT, MiscTypeFlag.S_SHIELD_SMALL);
         misc.bv = 50;
         misc.setInstantModeSwitch(true);
         String[] modes = { S_NO_SHIELD, S_ACTIVE_SHIELD, S_PASSIVE_SHIELD };
@@ -3917,7 +3917,7 @@ public static MiscType createISMediumShield() {
         misc.tonnage = 4;
         misc.criticalSlots = 5;
         misc.cost = 100000;
-        misc.flags = misc.flags.or(F_MEK_EQUIPMENT, MiscTypeFlag.S_SHIELD_MEDIUM);
+        misc.flags = misc.flags.or(F_SHIELD, F_MEK_EQUIPMENT, MiscTypeFlag.S_SHIELD_MEDIUM);
         misc.bv = 135;
         misc.setInstantModeSwitch(true);
         String[] modes = { S_NO_SHIELD, S_ACTIVE_SHIELD, S_PASSIVE_SHIELD };

megamek/unittests/megamek/common/EquipmentTypeTest.java

@@ -45,6 +45,7 @@
 import megamek.common.equipment.ArmorType;
 import megamek.common.equipment.EquipmentType;
 import megamek.common.equipment.EquipmentTypeLookup;
+import megamek.common.equipment.MiscType;
 import megamek.common.equipment.StructureType;
 import megamek.common.weapons.bayWeapons.TeleOperatedMissileBayWeapon;
 import org.junit.jupiter.api.Test;
@@ -120,6 +121,13 @@ void armorLookupSupportsDisplayInternalAndLegacyNames() {
         assertNull(EquipmentType.getArmorFromName("Unknown Armor Type"));
     }
 
+    @Test
+    void allShieldSizesHaveShieldFlag() {
+        assertTrue(MiscType.createISSmallShield().hasFlag(MiscType.F_SHIELD));
+        assertTrue(MiscType.createISMediumShield().hasFlag(MiscType.F_SHIELD));
+        assertTrue(MiscType.createISLargeShield().hasFlag(MiscType.F_SHIELD));
+    }
+
     private static class EquipmentTypeWithInheritedLookupNames extends EquipmentType {
         private EquipmentTypeWithInheritedLookupNames() {
             setInternalName("Parent");