Skip to content

Commit 3eb028f

Browse files
feat: Accept an app key + refresh token for Dropbox
1 parent 09d3256 commit 3eb028f

File tree

3 files changed

+22
-17
lines changed

3 files changed

+22
-17
lines changed

.github/workflows/ci_workflow.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ on:
1414
- pyproject.toml
1515
- tox.ini
1616
pull_request:
17-
branches: [main]
1817
paths:
1918
- .github/workflows/ci_workflow.yml
2019
- .github/workflows/constraints.txt

README.md

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -93,20 +93,18 @@ Optionally, the files definition can be provided by an external json file:
9393

9494
#### FTP
9595

96-
| Setting | Required | Default | Description |
97-
| :----------- | :------- | :------ | :---------------------- |
98-
| ftp | False | None | FTP connection settings |
99-
| ftp.host | True | None | FTP server host |
100-
| ftp.port | False | 21 | FTP server port |
101-
| ftp.username | False | None | FTP username |
102-
| ftp.password | False | None | FTP password |
103-
| ftp.encoding | False | utf-8 | FTP server encoding |
96+
| Setting | Required | Default | Description |
97+
| :----------- | :------- | :------ | :------------------ |
98+
| ftp.host | True | None | FTP server host |
99+
| ftp.port | False | 21 | FTP server port |
100+
| ftp.username | False | None | FTP username |
101+
| ftp.password | False | None | FTP password |
102+
| ftp.encoding | False | utf-8 | FTP server encoding |
104103

105104
#### GitHub
106105

107106
| Setting | Required | Default | Description |
108107
| :-------------- | :------- | :------ | :---------------------------------------------------------- |
109-
| github | False | None | GitHub connection settings |
110108
| github.org | True | None | GitHub organization or user where the repository is located |
111109
| github.repo | True | None | GitHub repository |
112110
| github.username | False | None | GitHub username |
@@ -141,10 +139,10 @@ Optionally, the files definition can be provided by an external json file:
141139

142140
#### Dropbox
143141

144-
| Setting | Required | Default | Description |
145-
| :------------ | :------- | :------ | :-------------------------- |
146-
| dropbox | False | None | Dropbox connection settings |
147-
| dropbox.token | True | None | Dropbox token |
142+
| Setting | Required | Default | Description |
143+
| :-------------------- | :------- | :------ | :-------------------- |
144+
| dropbox.app_key | True | None | Dropbox App key |
145+
| dropbox.refresh_token | True | None | Dropbox refresh token |
148146

149147
The token needs the `files.content.read` scope:
150148

@@ -158,7 +156,8 @@ The token needs the `files.content.read` scope:
158156
"add_metadata_columns": true,
159157
"filesystem": "dropbox",
160158
"dropbox": {
161-
"token": "...."
159+
"app_key": "your_app_key",
160+
"refresh_token": "your_refresh_token"
162161
},
163162
"files": [
164163
{

tap_csv/filesystem_config.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,18 @@
7676
"dropbox",
7777
th.ObjectType(
7878
th.Property(
79-
"token",
79+
"app_key",
80+
th.StringType,
81+
secret=True,
82+
required=True,
83+
description="Dropbox App key",
84+
),
85+
th.Property(
86+
"refresh_token",
8087
th.StringType,
8188
secret=True,
8289
required=True,
83-
description="Dropbox token",
90+
description="Dropbox refresh token",
8491
),
8592
),
8693
description="Dropbox connection settings",

0 commit comments

Comments
 (0)