Fix login error state test in CI

Author: Merkost

.github/workflows/test.yml

@@ -12,7 +12,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-java@v4
         with:
-          java-version: '17'
+          java-version: '21'
           distribution: 'temurin'
       - uses: actions/cache@v4
         with:

shared/src/androidUnitTest/kotlin/com/mobileprism/fishing/viewmodels/LoginViewModelTest.kt

@@ -2,11 +2,14 @@ package com.mobileprism.fishing.viewmodels
 
 import com.mobileprism.fishing.domain.entity.common.User
 import com.mobileprism.fishing.domain.repository.UserRepository
+import com.mobileprism.fishing.domain.repository.app.AnalyticsEvent
 import com.mobileprism.fishing.domain.repository.app.AnalyticsTracker
 import com.mobileprism.fishing.testutils.user
 import com.mobileprism.fishing.ui.viewmodels.LoginUiState
 import com.mobileprism.fishing.ui.viewmodels.LoginViewModel
+import io.mockk.every
 import io.mockk.mockk
+import io.mockk.verify
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.Flow
@@ -85,6 +88,21 @@ class LoginViewModelTest {
         val viewModel = LoginViewModel(repo, analyticsTracker)
         advanceUntilIdle()
 
+        val state = viewModel.uiState.value
+        assertIs<LoginUiState.Error>(state)
+        assertEquals("boom", state.message)
+        verify(exactly = 1) { analyticsTracker.logEvent(AnalyticsEvent.SignInError("boom")) }
+    }
+
+    @Test
+    fun `observeCurrentUser keeps Error state when analytics logging throws`() = runTest {
+        every { analyticsTracker.logEvent(any()) } throws RuntimeException("analytics failed")
+        val repo = fakeUserRepository(
+            currentUserFlow = flow { throw RuntimeException("boom") }
+        )
+        val viewModel = LoginViewModel(repo, analyticsTracker)
+        advanceUntilIdle()
+
         val state = viewModel.uiState.value
         assertIs<LoginUiState.Error>(state)
         assertEquals("boom", state.message)

shared/src/commonMain/kotlin/com/mobileprism/fishing/ui/viewmodels/LoginViewModel.kt

@@ -72,8 +72,8 @@ class LoginViewModel(
     }
 
     private fun onSignInError(error: Throwable) {
-        analyticsTracker.logEvent(AnalyticsEvent.SignInError(error.message))
-        Cedar.e(error.message ?: "Sign-in failed")
         _uiState.value = LoginUiState.Error(error.message)
+        runCatching { analyticsTracker.logEvent(AnalyticsEvent.SignInError(error.message)) }
+        runCatching { Cedar.e(error.message ?: "Sign-in failed") }
     }
 }