style: fix linter warnings

Author: mirceanis

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

@@ -11,6 +11,7 @@ import type {
   StateMetadata,
 } from '@metamask/base-controller';
 import { BaseController } from '@metamask/base-controller';
+import { encrypt } from '@metamask/eth-sig-util';
 import {
   type KeyringControllerGetStateAction,
   type KeyringControllerLockEvent,
@@ -26,6 +27,7 @@ import type {
   NetworkControllerUpdateNetworkAction,
 } from '@metamask/network-controller';
 import type { HandleSnapRequest } from '@metamask/snaps-controllers';
+import { hexToBytes } from '@noble/hashes/utils';
 
 import {
   saveInternalAccountToUserStorage,
@@ -37,6 +39,7 @@ import {
   startNetworkSyncing,
 } from './network-syncing/controller-integration';
 import { Env, UserStorage } from '../../sdk';
+import { byteArrayToBase64 } from '../../shared/encryption/utils';
 import type { UserStorageFeatureKeys } from '../../shared/storage-schema';
 import {
   type UserStoragePathWithFeatureAndKey,
@@ -54,8 +57,6 @@ import {
   createSnapEncryptionPublicKeyRequest,
   createSnapSignMessageRequest,
 } from '../authentication/auth-snap-requests';
-import { encrypt } from '@metamask/eth-sig-util';
-import { bytesToBase64, hexToBytes } from '@metamask/utils';
 
 const controllerName = 'UserStorageController';
 
@@ -387,7 +388,7 @@ export default class UserStorageController extends BaseController<
           encryptMessage: async (message: string, publicKeyHex: string) => {
             const erc1024Payload = encrypt({
               // eth-sig-util expects the public key to be in base64 format
-              publicKey: bytesToBase64(hexToBytes(publicKeyHex)),
+              publicKey: byteArrayToBase64(hexToBytes(publicKeyHex)),
               data: message,
               version: 'x25519-xsalsa20-poly1305',
             });
@@ -682,6 +683,7 @@ export default class UserStorageController extends BaseController<
 
   /**
    * Calls the snap to attempt to decrypt the message.
+   *
    * @param ciphertext - the encrypted text to decrypt.
    * @returns The decrypted message, if decryption was possible.
    */

packages/profile-sync-controller/src/controllers/user-storage/__fixtures__/mockMessenger.ts

@@ -1,7 +1,7 @@
 import type { NotNamespacedBy } from '@metamask/base-controller';
 import { Messenger } from '@metamask/base-controller';
-import type { EthKeyring } from '@metamask/keyring-internal-api';
 import { decrypt, type EthEncryptedData } from '@metamask/eth-sig-util';
+import type { EthKeyring } from '@metamask/keyring-internal-api';
 
 import type {
   AllowedActions,

packages/profile-sync-controller/src/controllers/user-storage/account-syncing/__fixtures__/test-utils.ts

@@ -31,7 +31,6 @@ export function mockUserStorageMessengerForAccountSyncing(options?: {
   messengerMocks.mockKeyringGetAccounts.mockImplementation(async () => {
     return (
       options?.accounts?.accountsList
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
         ?.filter((a) => a.metadata.keyring.type === KeyringTypes.hd)
         .map((a) => a.address) ??
       MOCK_INTERNAL_ACCOUNTS.ALL.map((a) => a.address)

packages/profile-sync-controller/src/controllers/user-storage/mocks/mockStorage.ts

@@ -3,8 +3,10 @@ import encryption, { createSHA256Hash } from '../../../shared/encryption';
 export const MOCK_STORAGE_KEY_SIGNATURE = 'mockStorageKey';
 export const MOCK_STORAGE_KEY = createSHA256Hash(MOCK_STORAGE_KEY_SIGNATURE);
 export const MOCK_STORAGE_DATA = JSON.stringify({ hello: 'world' });
-export const MOCK_ENCRYPTION_PRIVATE_KEY = '29411742c5cf3d7eb1a0cf57230488900e86778c876078fb87164ec6864841cd';
-export const MOCK_ENCRYPTION_PUBLIC_KEY = '37a3160dda3e0086a89974854f1ba7c3e6b1bc960e06311bcc4c15264d95ee36';
+export const MOCK_ENCRYPTION_PRIVATE_KEY =
+  '29411742c5cf3d7eb1a0cf57230488900e86778c876078fb87164ec6864841cd';
+export const MOCK_ENCRYPTION_PUBLIC_KEY =
+  '37a3160dda3e0086a89974854f1ba7c3e6b1bc960e06311bcc4c15264d95ee36';
 
 // NOTE - using encryption.encryptString directly in fixtures causes issues on mobile.
 // This is because this fixture is getting added in at run time. Will be improved once we support multiple exports

packages/profile-sync-controller/src/controllers/user-storage/network-syncing/controller-integration.ts

@@ -48,8 +48,6 @@ export function startNetworkSyncing(props: StartNetworkSyncingProps) {
   try {
     messenger.subscribe(
       'NetworkController:networkRemoved',
-
-      // eslint-disable-next-line @typescript-eslint/no-misused-promises
       async (networkConfiguration) => {
         try {
           // If blocked (e.g. we have not yet performed a main-sync), then we should not perform any mutations