Skip to content

Keyring metadata mismatch for unsupported keyrings #5701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mikesposito opened this issue Apr 23, 2025 · 0 comments · May be fixed by #5725
Open

Keyring metadata mismatch for unsupported keyrings #5701

mikesposito opened this issue Apr 23, 2025 · 0 comments · May be fixed by #5725
Assignees
@mikesposito
Labels
bug Something isn't working team-wallet-framework

Comments

@mikesposito
Copy link
Member

mikesposito commented Apr 23, 2025 •
edited
Loading

If a KeyringController consumer drops support for a keyring type, or a keyring builder is removed, or a keyring fails to initialise for some reason, the keyring will be moved to unsupportedKeyrings but the related keyring metadata introduced since multi-srp support will not be removed. This means that users will be locked out of their wallet, as a Keyrings metadata length mismatch will be thrown on wallet unlock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikesposito mikesposito

Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove metadata for unsupported keyrings MetaMask/core
1 participant
@mikesposito