Skip to content

Commit 20d1a20

Browse files
MajorLiftMajorLift
committed
Wrap hook calls in tests with renderHook 
1 parent e5d703d commit 20d1a20

File tree

4 files changed

+256
-193
lines changed

4 files changed

+256
-193
lines changed

‎ui/hooks/useIsOriginalNativeTokenSymbol.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import { useIsOriginalNativeTokenSymbol } from './useIsOriginalNativeTokenSymbol
88

99
const arrangeMocks = () => {
1010
// Mock Selectors
11-
const mockUseSafeChainsListValidationSelector = jest
12-
.spyOn(SelectorsModule, 'useSafeChainsListValidationSelector')
11+
const mockGetUseSafeChainsListValidation = jest
12+
.spyOn(SelectorsModule, 'getUseSafeChainsListValidation')
1313
.mockReturnValue(true);
1414

1515
const createMockProviderConfig = () =>
@@ -26,7 +26,7 @@ const arrangeMocks = () => {
2626
.mockResolvedValue(true);
2727

2828
return {
29-
mockUseSafeChainsListValidationSelector,
29+
mockGetUseSafeChainsListValidation,
3030
createMockProviderConfig,
3131
mockGetMultichainCurrentNetwork,
3232
mockIsOriginalNativeTokenSymbol,

‎ui/hooks/useName.test.ts‎

Lines changed: 57 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { renderHook } from '@testing-library/react-hooks';
12
import {
23
FALLBACK_VARIATION,
34
NameControllerState,
@@ -47,13 +48,15 @@ describe('useName', () => {
4748
it('returns default values if no state', () => {
4849
getNamesMock.mockReturnValue({} as NameControllerState['names']);
4950

50-
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_MOCK);
51+
renderHook(() => {
52+
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_MOCK);
5153

52-
expect(nameEntry).toStrictEqual<NameEntry>({
53-
name: null,
54-
sourceId: null,
55-
origin: null,
56-
proposedNames: {},
54+
expect(nameEntry).toStrictEqual<NameEntry>({
55+
name: null,
56+
sourceId: null,
57+
origin: null,
58+
proposedNames: {},
59+
});
5760
});
5861
});
5962

@@ -71,13 +74,15 @@ describe('useName', () => {
7174
},
7275
});
7376

74-
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_MOCK);
77+
renderHook(() => {
78+
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_MOCK);
7579

76-
expect(nameEntry).toStrictEqual<NameEntry>({
77-
name: null,
78-
sourceId: null,
79-
origin: null,
80-
proposedNames: {},
80+
expect(nameEntry).toStrictEqual<NameEntry>({
81+
name: null,
82+
sourceId: null,
83+
origin: null,
84+
proposedNames: {},
85+
});
8186
});
8287
});
8388

@@ -95,13 +100,15 @@ describe('useName', () => {
95100
},
96101
});
97102

98-
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_MOCK);
103+
renderHook(() => {
104+
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_MOCK);
99105

100-
expect(nameEntry).toStrictEqual<NameEntry>({
101-
name: NAME_MOCK,
102-
sourceId: SOURCE_ID_MOCK,
103-
proposedNames: PROPOSED_NAMES_MOCK,
104-
origin: ORIGIN_MOCK,
106+
expect(nameEntry).toStrictEqual<NameEntry>({
107+
name: NAME_MOCK,
108+
sourceId: SOURCE_ID_MOCK,
109+
proposedNames: PROPOSED_NAMES_MOCK,
110+
origin: ORIGIN_MOCK,
111+
});
105112
});
106113
});
107114

@@ -119,13 +126,15 @@ describe('useName', () => {
119126
},
120127
});
121128

122-
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_2_MOCK);
129+
renderHook(() => {
130+
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_2_MOCK);
123131

124-
expect(nameEntry).toStrictEqual<NameEntry>({
125-
name: NAME_MOCK,
126-
sourceId: SOURCE_ID_MOCK,
127-
proposedNames: PROPOSED_NAMES_MOCK,
128-
origin: ORIGIN_MOCK,
132+
expect(nameEntry).toStrictEqual<NameEntry>({
133+
name: NAME_MOCK,
134+
sourceId: SOURCE_ID_MOCK,
135+
proposedNames: PROPOSED_NAMES_MOCK,
136+
origin: ORIGIN_MOCK,
137+
});
129138
});
130139
});
131140

@@ -144,13 +153,15 @@ describe('useName', () => {
144153
},
145154
});
146155

147-
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_2_MOCK);
156+
renderHook(() => {
157+
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_2_MOCK);
148158

149-
expect(nameEntry).toStrictEqual<NameEntry>({
150-
name: NAME_MOCK,
151-
sourceId: SOURCE_ID_MOCK,
152-
proposedNames: PROPOSED_NAMES_MOCK,
153-
origin: ORIGIN_MOCK,
159+
expect(nameEntry).toStrictEqual<NameEntry>({
160+
name: NAME_MOCK,
161+
sourceId: SOURCE_ID_MOCK,
162+
proposedNames: PROPOSED_NAMES_MOCK,
163+
origin: ORIGIN_MOCK,
164+
});
154165
});
155166
});
156167

@@ -174,13 +185,15 @@ describe('useName', () => {
174185
},
175186
});
176187

177-
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_2_MOCK);
188+
renderHook(() => {
189+
const nameEntry = useName(VALUE_MOCK, TYPE_MOCK, VARIATION_2_MOCK);
178190

179-
expect(nameEntry).toStrictEqual<NameEntry>({
180-
name: NAME_MOCK,
181-
proposedNames: {},
182-
sourceId: SOURCE_ID_MOCK,
183-
origin: ORIGIN_MOCK,
191+
expect(nameEntry).toStrictEqual<NameEntry>({
192+
name: NAME_MOCK,
193+
proposedNames: {},
194+
sourceId: SOURCE_ID_MOCK,
195+
origin: ORIGIN_MOCK,
196+
});
184197
});
185198
});
186199
});
@@ -199,13 +212,15 @@ describe('useName', () => {
199212
},
200213
});
201214

202-
const nameEntry = useName('0xAbC123', TYPE_MOCK, VARIATION_MOCK);
215+
renderHook(() => {
216+
const nameEntry = useName('0xAbC123', TYPE_MOCK, VARIATION_MOCK);
203217

204-
expect(nameEntry).toStrictEqual<NameEntry>({
205-
name: NAME_MOCK,
206-
sourceId: SOURCE_ID_MOCK,
207-
proposedNames: PROPOSED_NAMES_MOCK,
208-
origin: ORIGIN_MOCK,
218+
expect(nameEntry).toStrictEqual<NameEntry>({
219+
name: NAME_MOCK,
220+
sourceId: SOURCE_ID_MOCK,
221+
proposedNames: PROPOSED_NAMES_MOCK,
222+
origin: ORIGIN_MOCK,
223+
});
209224
});
210225
});
211226
});

‎ui/hooks/useOriginTrustSignals.test.ts‎

Lines changed: 64 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { renderHook } from '@testing-library/react-hooks';
12
import { RecommendedAction } from '@metamask/phishing-controller';
23
import { getUrlScanCacheResult } from '../selectors/selectors';
34
import { TrustSignalDisplayState } from './useTrustSignals';
@@ -29,16 +30,18 @@ describe('useOriginTrustSignals', () => {
2930
it('returns unknown state when selector returns undefined', () => {
3031
getUrlScanCacheResultMock.mockReturnValue(undefined);
3132

32-
const result = useOriginTrustSignals('');
33-
34-
expect(result).toStrictEqual({
35-
state: TrustSignalDisplayState.Unknown,
36-
label: null,
33+
renderHook(() => {
34+
const result = useOriginTrustSignals('');
35+
36+
expect(result).toStrictEqual({
37+
state: TrustSignalDisplayState.Unknown,
38+
label: null,
39+
});
40+
expect(getUrlScanCacheResultMock).toHaveBeenCalledWith(
41+
undefined,
42+
undefined,
43+
);
3744
});
38-
expect(getUrlScanCacheResultMock).toHaveBeenCalledWith(
39-
undefined,
40-
undefined,
41-
);
4245
});
4346

4447
it('returns malicious state when recommendedAction is Block', () => {
@@ -50,16 +53,18 @@ describe('useOriginTrustSignals', () => {
5053
timestamp: TIMESTAMP_MOCK,
5154
});
5255

53-
const result = useOriginTrustSignals(ORIGIN_MOCK);
54-
55-
expect(result).toStrictEqual({
56-
state: TrustSignalDisplayState.Malicious,
57-
label: null,
56+
renderHook(() => {
57+
const result = useOriginTrustSignals(ORIGIN_MOCK);
58+
59+
expect(result).toStrictEqual({
60+
state: TrustSignalDisplayState.Malicious,
61+
label: null,
62+
});
63+
expect(getUrlScanCacheResultMock).toHaveBeenCalledWith(
64+
undefined,
65+
DOMAIN_NAME_MOCK,
66+
);
5867
});
59-
expect(getUrlScanCacheResultMock).toHaveBeenCalledWith(
60-
undefined,
61-
DOMAIN_NAME_MOCK,
62-
);
6368
});
6469

6570
it('returns warning state when recommendedAction is Warn', () => {
@@ -71,11 +76,13 @@ describe('useOriginTrustSignals', () => {
7176
timestamp: TIMESTAMP_MOCK,
7277
});
7378

74-
const result = useOriginTrustSignals(ORIGIN_MOCK);
79+
renderHook(() => {
80+
const result = useOriginTrustSignals(ORIGIN_MOCK);
7581

76-
expect(result).toStrictEqual({
77-
state: TrustSignalDisplayState.Warning,
78-
label: null,
82+
expect(result).toStrictEqual({
83+
state: TrustSignalDisplayState.Warning,
84+
label: null,
85+
});
7986
});
8087
});
8188

@@ -88,11 +95,13 @@ describe('useOriginTrustSignals', () => {
8895
timestamp: TIMESTAMP_MOCK,
8996
});
9097

91-
const result = useOriginTrustSignals(ORIGIN_MOCK);
98+
renderHook(() => {
99+
const result = useOriginTrustSignals(ORIGIN_MOCK);
92100

93-
expect(result).toStrictEqual({
94-
state: TrustSignalDisplayState.Verified,
95-
label: null,
101+
expect(result).toStrictEqual({
102+
state: TrustSignalDisplayState.Verified,
103+
label: null,
104+
});
96105
});
97106
});
98107

@@ -105,11 +114,13 @@ describe('useOriginTrustSignals', () => {
105114
timestamp: TIMESTAMP_MOCK,
106115
});
107116

108-
const result = useOriginTrustSignals(ORIGIN_MOCK);
117+
renderHook(() => {
118+
const result = useOriginTrustSignals(ORIGIN_MOCK);
109119

110-
expect(result).toStrictEqual({
111-
state: TrustSignalDisplayState.Unknown,
112-
label: null,
120+
expect(result).toStrictEqual({
121+
state: TrustSignalDisplayState.Unknown,
122+
label: null,
123+
});
113124
});
114125
});
115126

@@ -122,11 +133,13 @@ describe('useOriginTrustSignals', () => {
122133
timestamp: TIMESTAMP_MOCK,
123134
});
124135

125-
const result = useOriginTrustSignals(ORIGIN_MOCK);
136+
renderHook(() => {
137+
const result = useOriginTrustSignals(ORIGIN_MOCK);
126138

127-
expect(result).toStrictEqual({
128-
state: TrustSignalDisplayState.Unknown,
129-
label: null,
139+
expect(result).toStrictEqual({
140+
state: TrustSignalDisplayState.Unknown,
141+
label: null,
142+
});
130143
});
131144
});
132145

@@ -139,26 +152,30 @@ describe('useOriginTrustSignals', () => {
139152
timestamp: TIMESTAMP_MOCK,
140153
});
141154

142-
const result = useOriginTrustSignals(ORIGIN_MOCK);
155+
renderHook(() => {
156+
const result = useOriginTrustSignals(ORIGIN_MOCK);
143157

144-
expect(result).toStrictEqual({
145-
state: TrustSignalDisplayState.Unknown,
146-
label: null,
158+
expect(result).toStrictEqual({
159+
state: TrustSignalDisplayState.Unknown,
160+
label: null,
161+
});
147162
});
148163
});
149164

150165
it('returns unknown state when origin is invalid URL', () => {
151166
getUrlScanCacheResultMock.mockReturnValue(undefined);
152167

153-
const result = useOriginTrustSignals('not-a-valid-url');
154-
155-
expect(result).toStrictEqual({
156-
state: TrustSignalDisplayState.Unknown,
157-
label: null,
168+
renderHook(() => {
169+
const result = useOriginTrustSignals('not-a-valid-url');
170+
171+
expect(result).toStrictEqual({
172+
state: TrustSignalDisplayState.Unknown,
173+
label: null,
174+
});
175+
expect(getUrlScanCacheResultMock).toHaveBeenCalledWith(
176+
undefined,
177+
undefined,
178+
);
158179
});
159-
expect(getUrlScanCacheResultMock).toHaveBeenCalledWith(
160-
undefined,
161-
undefined,
162-
);
163180
});
164181
});

0 commit comments

Comments
 (0)