fix: flaky test Multichain API Call wallet_createSession (#31603)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This spec fails, as after the MM dialog is closed, we perform actions in
the multichain test dapp (sending window requests). The problem is that
when we do this, we are still in the "context" of the dialog window,
which was closed. This causes the browser to sometimes hang, and then
the spec fails with a timeout, and cannot terminate properly.

We should make sure the dialog is closed after we confirm/cancel the
popup, and then switch into an existing window (multi chain test dapp)
to perform the subsequent window api calls

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31603?quickstart=1)

## **Related issues**

Fixes: ci failure:
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/131730/workflows/65eb770f-9142-44b2-a757-0dd44b4a9ec2/jobs/4651782/tests#failed-test-0

## **Manual testing steps**

1. check ci flask e2e job

![Screenshot from 2025-04-04
15-06-59](https://github.com/user-attachments/assets/5cce394c-c7eb-4b5f-93bc-bd28a58a95ed)

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: seaona

test/e2e/flask/multichain-api/wallet_createSession.spec.ts

@@ -44,8 +44,13 @@ describeBrowserOnly(Browser.CHROME, 'Multichain API', function () {
             ...scopesToIgnore,
           ]);
 
-          await driver.clickElement({ text: 'Connect', tag: 'button' });
-
+          await driver.clickElementAndWaitForWindowToClose({
+            text: 'Connect',
+            tag: 'button',
+          });
+          await driver.switchToWindowWithTitle(
+            WINDOW_TITLES.MultichainTestDApp,
+          );
           const getSessionResult = await testDapp.getSession();
 
           for (const scope of scopesToIgnore) {
@@ -90,7 +95,13 @@ describeBrowserOnly(Browser.CHROME, 'Multichain API', function () {
             [SECOND_ACCOUNT_IN_WALLET, ACCOUNT_NOT_IN_WALLET],
           );
 
-          await driver.clickElement({ text: 'Connect', tag: 'button' });
+          await driver.clickElementAndWaitForWindowToClose({
+            text: 'Connect',
+            tag: 'button',
+          });
+          await driver.switchToWindowWithTitle(
+            WINDOW_TITLES.MultichainTestDApp,
+          );
 
           const getSessionResult = await testDapp.getSession();
           /**
@@ -202,7 +213,13 @@ describeBrowserOnly(Browser.CHROME, 'Multichain API', function () {
             await permissionsTab.click();
             await updateNetworkCheckboxes(driver, ['Localhost 8545']);
 
-            await driver.clickElement({ text: 'Connect', tag: 'button' });
+            await driver.clickElementAndWaitForWindowToClose({
+              text: 'Connect',
+              tag: 'button',
+            });
+            await driver.switchToWindowWithTitle(
+              WINDOW_TITLES.MultichainTestDApp,
+            );
 
             const getSessionResult = await testDapp.getSession();
 
@@ -282,7 +299,10 @@ describeBrowserOnly(Browser.CHROME, 'Multichain API', function () {
 
             await addAccountInWalletAndAuthorize(driver);
 
-            await driver.clickElement({ text: 'Connect', tag: 'button' });
+            await driver.clickElementAndWaitForWindowToClose({
+              text: 'Connect',
+              tag: 'button',
+            });
             await driver.switchToWindowWithTitle(
               WINDOW_TITLES.MultichainTestDApp,
             );
@@ -392,7 +412,13 @@ describeBrowserOnly(Browser.CHROME, 'Multichain API', function () {
               await driver.clickElement(`input[name="${scope}"]`),
           );
           await testDapp.initCreateSessionScopes(NEW_SCOPES, [TREZOR_ACCOUNT]);
-          await driver.clickElement({ text: 'Connect', tag: 'button' });
+          await driver.clickElementAndWaitForWindowToClose({
+            text: 'Connect',
+            tag: 'button',
+          });
+          await driver.switchToWindowWithTitle(
+            WINDOW_TITLES.MultichainTestDApp,
+          );
           await driver.delay(largeDelayMs);
 
           const newgetSessionResult = await testDapp.getSession();