release(runway): cherry-pick fix: update package to avoid yarn audit issue (#38367)

- fix: update package to avoid yarn audit issue (#38348)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Resolve `node-forge` to ^1.3.2 in order to pass the audit.

DO NOT MERGE unless someone with security privileges clears it.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38348?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Adds a safe click helper for the backup reminder and updates affected
e2e tests to use it post-onboarding.
> 
> - **E2E**:
> - **Page Object (`test/e2e/page-objects/pages/home/homepage.ts`)**:
Add `clickBackupRemindMeLaterButtonSafe` using
`driver.clickElementSafe`.
>   - **Tests**:
> - Update `test/e2e/tests/account/incremental-security.spec.ts` to use
`clickBackupRemindMeLaterButtonSafe` after onboarding.
> - Update `test/e2e/tests/settings/change-password.spec.ts` to use
`clickBackupRemindMeLaterButtonSafe` after onboarding.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
17f5b4a. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Mark Stacey <[email protected]>
[54fd624](54fd624)

Co-authored-by: Bernardo Garces Chapero <[email protected]>
Co-authored-by: Mark Stacey <[email protected]>

Author: 3 people

test/e2e/page-objects/pages/home/homepage.ts

@@ -193,6 +193,10 @@ class HomePage {
     );
   }
 
+  async clickBackupRemindMeLaterButtonSafe(): Promise<void> {
+    await this.driver.clickElementSafe(this.backupRemindMeLaterButton);
+  }
+
   async closeSurveyToast(surveyName: string): Promise<void> {
     console.log(`Close survey toast for ${surveyName}`);
     await this.driver.waitForSelector({

test/e2e/tests/account/incremental-security.spec.ts

@@ -96,7 +96,8 @@ describe('Incremental Security', function (this: Suite) {
         // copy the wallet address
         const homePage = new HomePage(driver);
         await homePage.checkPageIsLoaded();
-        await homePage.clickBackupRemindMeLaterButton();
+        // TODO: This is a temporary fix to unblock CI. Remove this once the issue is fixed.
+        await homePage.clickBackupRemindMeLaterButtonSafe();
         await homePage.headerNavbar.clickAddressCopyButton();
 
         // switched to Dapp and send eth to the current account

test/e2e/tests/settings/change-password.spec.ts

@@ -72,7 +72,9 @@ describe('Change wallet password', function () {
         });
         const homePage = new HomePage(driver);
         await homePage.checkPageIsLoaded();
-        await homePage.clickBackupRemindMeLaterButton();
+
+        // TODO: This is a temporary fix to unblock CI. Remove this once the issue is fixed.
+        await homePage.clickBackupRemindMeLaterButtonSafe();
 
         await doPasswordChangeAndLockWallet(driver, OLD_PASSWORD, NEW_PASSWORD);
 

yarn.lock

@@ -34032,9 +34032,9 @@ __metadata:
   linkType: hard
 
 "node-forge@npm:^1, node-forge@npm:^1.2.1":
-  version: 1.3.1
-  resolution: "node-forge@npm:1.3.1"
-  checksum: 10/05bab6868633bf9ad4c3b1dd50ec501c22ffd69f556cdf169a00998ca1d03e8107a6032ba013852f202035372021b845603aeccd7dfcb58cdb7430013b3daa8d
+  version: 1.3.2
+  resolution: "node-forge@npm:1.3.2"
+  checksum: 10/dcc54aaffe0cf52367214a20c0032aa9b209d9095dd14526504f1972d1900a07e96046b3684cb0c8d0cc3d48744dd18e02b7b447ab28fac615ffb850beeabf18
   languageName: node
   linkType: hard