release(runway): cherry-pick fix: Remove tabs permission to avoid new warnings cp-13.10.1
#38146
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew warnings cp-13.10.1 (#38075) ## **Description** The recent addition of the `tabs` permission will result in new permission warnings upon update, which is extremely disruptive and is something we'd never do except as a last resort. The permission wasn't actually needed, and has been removed. This removal uncovered a bug in our Webpack build (the `tabs` permission was erroneously only added for MV2 test builds, but we need it for MV3 test builds as well), which has been fixed. [](https://codespaces.new/MetaMask/metamask-extension/pull/38075?quickstart=1) ## **Changelog** CHANGELOG entry: Remove unnecessary extension permission ## **Related issues** N/A ## **Manual testing steps** Test that the sidepanel still works in general. Particularly with dapp confirmations, and the "Connected status" indicator, and current selected dapp. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes `tabs` from the MV3 manifest and updates the build transform to add `tabs` only for test builds (all manifest versions). > > - **Manifest (MV3)**: > - Remove `tabs` from `permissions` in `app/manifest/v3/_base.json`. > - **Build/Manifest transform**: > - Update `transformManifest` in `development/webpack/utils/plugins/ManifestPlugin/helpers.ts` to add `tabs` when `args.test` is true, regardless of `manifest_version`. > - Retains error if `tabs` already exists and continues adding dev/test manifest key. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 862591e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
gauthierpetetin
approved these changes
Nov 21, 2025
Collaborator
Builds ready [7778231]
UI Startup Metrics (1242 ± 96 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
metamaskbot
added
the
release-13.10.1
Collaborator
|
No release label on PR. Adding release label release-13.10.1 on PR, as PR was cherry-picked in branch 13.10.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/38075?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tabspermission to avoid new warnings cp-13.10.1 (fix: Removetabspermission to avoid new warnings cp-13.10.1 #38075)Description
The recent addition of the
tabspermission will result in newpermission warnings upon update, which is extremely disruptive and is
something we'd never do except as a last resort.
The permission wasn't actually needed, and has been removed. This
removal uncovered a bug in our Webpack build (the
tabspermission waserroneously only added for MV2 test builds, but we need it for MV3 test
builds as well), which has been fixed.
Changelog
CHANGELOG entry: Remove unnecessary extension permission
Related issues
N/A
Manual testing steps
Test that the sidepanel still works in general. Particularly with dapp
confirmations, and the "Connected status" indicator, and current
selected dapp.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Removes the
tabspermission from the MV3 base manifest.app/manifest/v3/_base.jsonto removepermissionsentrytabs.Written by Cursor Bugbot for commit 7778231. This will update automatically on new commits. Configure here.
bba4201