fix: adjusted height of bottom sheet conditionally and dapp network avatar no longer shows when dapp is requesting network permissions

Author: vinnyhoward

app/components/UI/PermissionsSummary/PermissionsSummary.styles.ts

@@ -10,13 +10,14 @@ const createStyles = (params: {
   vars: {
     isRenderedAsBottomSheet: boolean | undefined;
     nonTabView: boolean | undefined;
+    fullNonTabView: boolean | undefined;
   };
 }) => {
   const { theme, vars } = params;
   const { colors, typography } = theme;
-  const { isRenderedAsBottomSheet, nonTabView } = vars;
+  const { isRenderedAsBottomSheet, nonTabView, fullNonTabView } = vars;
 
-  const tabHeight = nonTabView ? 400 : undefined;
+  const tabHeight = fullNonTabView ? 400 : 325;
   const bottomSheetHeight = isRenderedAsBottomSheet ? undefined : '100%';
   const height = nonTabView ? tabHeight : bottomSheetHeight;
 

app/components/UI/PermissionsSummary/PermissionsSummary.tsx

@@ -99,11 +99,13 @@ const PermissionsSummary = ({
   showPermissionsOnly = false,
 }: PermissionsSummaryProps) => {
   const nonTabView = showAccountsOnly || showPermissionsOnly;
+  const fullNonTabView = showAccountsOnly && showPermissionsOnly;
 
   const { colors } = useTheme();
   const { styles } = useStyles(styleSheet, {
     isRenderedAsBottomSheet,
     nonTabView,
+    fullNonTabView,
   });
   const navigation = useNavigation();
   const { navigate } = navigation;
@@ -157,7 +159,9 @@ const PermissionsSummary = ({
     const url = currentPageInformation.url;
     const iconTitle = getHost(currentEnsName || url);
 
-    return isPerDappSelectedNetworkEnabled() && isAlreadyConnected ? (
+    return isPerDappSelectedNetworkEnabled() &&
+      isAlreadyConnected &&
+      !nonTabView ? (
       <View style={[styles.domainLogoContainer, styles.assetLogoContainer]}>
         <TouchableOpacity
           onPress={switchNetwork}

app/components/UI/PermissionsSummary/__snapshots__/PermissionsSummary.test.tsx.snap

@@ -1799,7 +1799,7 @@ exports[`PermissionsSummary should render only the account permissions card when
           "backgroundColor": "#f3f5f9",
           "borderTopLeftRadius": 20,
           "borderTopRightRadius": 20,
-          "height": 400,
+          "height": 310,
           "justifyContent": "flex-start",
           "paddingTop": 16,
         },
@@ -2497,7 +2497,7 @@ exports[`PermissionsSummary should render only the network permissions card when
           "backgroundColor": "#f3f5f9",
           "borderTopLeftRadius": 20,
           "borderTopRightRadius": 20,
-          "height": 400,
+          "height": 310,
           "justifyContent": "flex-start",
           "paddingTop": 16,
         },