Skip to content

Commit b3791df

Browse files
authored
chore: remove deprecated network selector from settings (#21614)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** The network selector in the settings view is very outdated and inconsistent with the new Bip-44 UI. This is causing: - New bugs raised - Double Developer effort when dealing with networks - Inconsistencies Therefore, after consulting with @Tlees-MMI and @alfeng6 we have come to the conclussion of fully removing it from the settings view. From now on if users want to do anything related to network management they can use the network selector from the Wallet Screen. Here is part of the discussion: <img width="1092" height="817" alt="image" src="https://github.com/user-attachments/assets/c0af76be-95de-4e2e-9732-4a1732f284b6" /> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: removal of network selector in settings ## **Related issues** Fixes: - https://consensyssoftware.atlassian.net/browse/ASSETS-1354 | #20458 - https://consensyssoftware.atlassian.net/browse/ASSETS-1339 | #20362 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/f7d86172-3fff-4c64-b185-c4a6698e18f5 ### **After** https://github.com/user-attachments/assets/00b0f9f2-cad2-4aad-8b2d-4f21cf86f0ed ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Removes the deprecated Networks settings screen and entry, shifting network management to the wallet network switcher and updating navigation, unit tests, and e2e flows accordingly. > > - **Settings**: > - Remove `Networks` drawer item and related handler from `Views/Settings`. > - **Navigation**: > - Remove `NetworksSettings` screen from `MainNavigator`. > - **NetworksSettings Removal**: > - Delete `Views/Settings/NetworksSettings` component, unit tests, and snapshots. > - **Tests/E2E**: > - Update `Settings` snapshot and unit tests to exclude `networks-settings`. > - Remove `NETWORKS` selector and page object methods. > - Refactor e2e flows to manage networks via wallet network switcher (`WalletView`/`NetworkListModal`) instead of Settings (e.g., add/delete networks, permission cleanup, localhost helper). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit d94fbf5. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 3093aac commit b3791df

File tree

12 files changed

+11
-2294
lines changed

12 files changed

+11
-2294
lines changed

app/components/Nav/Main/MainNavigator.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import AdvancedSettings from '../../Views/Settings/AdvancedSettings';
1313
import BackupAndSyncSettings from '../../Views/Settings/Identity/BackupAndSyncSettings';
1414
import SecuritySettings from '../../Views/Settings/SecuritySettings';
1515
import ExperimentalSettings from '../../Views/Settings/ExperimentalSettings';
16-
import NetworksSettings from '../../Views/Settings/NetworksSettings';
1716
import NotificationsSettings from '../../Views/Settings/NotificationsSettings';
1817
import NotificationsView from '../../Views/Notifications';
1918
import NotificationsDetails from '../../Views/Notifications/Details';
@@ -394,11 +393,6 @@ const SettingsFlow = () => (
394393
component={ExperimentalSettings}
395394
options={ExperimentalSettings.navigationOptions}
396395
/>
397-
<Stack.Screen
398-
name="NetworksSettings"
399-
component={NetworksSettings}
400-
options={NetworksSettings.navigationOptions}
401-
/>
402396
<Stack.Screen
403397
name="CompanySettings"
404398
component={AppInformation}

0 commit comments

Comments
 (0)