Update settings.json code block for shell integration (#860)
#860
Conversation
|
Learn Build status updates of commit be3bb47: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@microsoft-github-policy-service agree |
|
Learn Build status updates of commit 40786b1: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
| { "keys": "ctrl+down", "command": { "action": "scrollToMark", "direction": "next" }, }, | ||
|
|
||
| // Add the ability to select a whole command (or its output) | ||
| { "command": { "action": "selectOutput", "direction": "prev" }, }, |
There was a problem hiding this comment.
so, this one's actually our bad! These commands definitely do exist if bound, they just aren't in the actions list by default.
There was a problem hiding this comment.
Gotcha I mis-assumed since my editor was complaining about them being invalid values, I've added them back into the docs. Is it worth making a PR to add them into the schema json or is there a reason they've been left out in the meantime?
|
Learn Build status updates of commit 06f49f0: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 4214a0f: ✅ Validation status: passed
For more details, please refer to the build report. |
…s#860) Based on the current schema (and messing with my own personal WT `settings.json`), it looks like declaring an `id` bound to defined `actions` & then referencing this id in `keybindings` is preferred over using the `keys` prop within elements of the `actions` array. `select{Command|Output}` were also emitting errors since they are not officially defined in the schema but they are valid actions as clarified by @DHowett & verified in my usage--added `keys` to docs
|
Learn Build status updates of commit ced6aef: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 4788417: ✅ Validation status: passed
For more details, please refer to the build report. |
david-ly
changed the title
settings.json codeblocksettings.json code block for shell integration (#860)
5 participants
Updated the
settings.jsoncode block according to the current schemaactionsarray elems to include declaredids referenced in the addedkeybindingsarray to define shortcut keystrokes (& addedkeysforselect{Command|Output}actions)