Data types in riven::models::match_v5::Challenges

[BMorinBlitz]

Riot can't seem to make-up their mind about these. i32, f32, f64. It's wild card madness and in Rust these end up being deserialization errors, compile errors, etc.

We had to make a local edit to make these all f64 while the dust settles.
Is there a better way to make these sorts of things less fragile?

[MingweiSamuel]

I had them overridden by riotapi-schema to be f64 for a while, ever since Challenges was first added and was almost completely undocumented. RiotGames/developer-relations#928

They've updated their docs though so recently I went through and removed most of the overrides, only 9 fields left needing overrides: RiotGames/developer-relations#928 (comment) , so although annoying it should be (mostly) settled

If you do get any deserialization errors, please let me know as that would be a considered a bug in the schema

In terms of ways to make it less fragile, not sure, perhaps a feature flag to make it use f64, or to treat ChallengesDto as a HashMap<String, f64>

[BMorinBlitz]

If you do get any deserialization errors, please let me know as that would be a considered a bug in the schema

Will do, the challenge I had is the error I would get back from serde isn't very helpful without the full source data. Seems like that's the problem you're trying so solve in your branch?

[MingweiSamuel]

For bug reports, just the match ID is enough, can test locally with that. Yes the eserde feature will show all the mismatching parts of the json schema. It may be a tiny bit slower on the main code paths though (and naturally a good amount slower on the hopefully-rare error reporting path)

[BMorinBlitz]

This match seemed to have challenges with the version up on crates.io, but I was juggling a bunch of changes in a private branch until I landed on setting everything to f64.
NA1_5245486208