feat: Add support to skip confirmation (#10)

* feat: Add support to skip confirmation

* feat: Add support to skip confirmation

Author: Mng-dev-ai

README.md

@@ -13,6 +13,7 @@ Django Modal Actions is a reusable Django app that provides a convenient way to
 - Support for both list-view and object-view actions
 - Customizable modal forms
 - AJAX-based form submission
+- Skip confirmation dialog for immediate action execution
 
 ## Requirements
 
@@ -211,6 +212,47 @@ def approve(self, request, obj, form_data=None):
 
 In this case, the user must both have the `can_approve_items` permission and be a staff member to see and use the approve action.
 
+## Skip Confirmation Dialog
+
+Sometimes you may want to execute an action immediately without showing a confirmation dialog. You can use the `skip_confirmation` parameter to achieve this:
+
+```python
+from django.contrib import admin
+from django_modal_actions import ModalActionMixin, modal_action
+
+@admin.register(YourModel)
+class YourModelAdmin(ModalActionMixin, admin.ModelAdmin):
+    list_display = ['name', 'status']
+    modal_actions = ['toggle_status']
+    list_modal_actions = ['bulk_toggle_status']
+
+    @modal_action(
+        modal_header="Toggle Status",
+        skip_confirmation=True
+    )
+    def toggle_status(self, request, obj, form_data=None):
+        if obj.status == 'active':
+            obj.status = 'inactive'
+        else:
+            obj.status = 'active'
+        obj.save()
+        return f"{obj} status toggled to {obj.status}"
+
+    @modal_action(
+        modal_header="Bulk Toggle Status",
+        skip_confirmation=True
+    )
+    def bulk_toggle_status(self, request, queryset, form_data=None):
+        for obj in queryset:
+            obj.status = 'inactive' if obj.status == 'active' else 'active'
+            obj.save()
+        return f"Toggled status for {queryset.count()} items"
+```
+
+In this example, both actions will execute immediately when clicked, without showing a confirmation modal. The page will reload automatically after the action completes.
+
+**Important Note**: You cannot use `skip_confirmation=True` together with `form_class`. The skip confirmation feature is designed for actions that don't require any user input. If you need to collect form data, the modal must be shown to display the form.
+
 ## Custom Admin Templates
 
 If you need to customize the admin templates while still using the modal actions, you can override the `change_form_template` and `change_list_template` in your ModelAdmin class. Here's how to do it:

django_modal_actions/mixins.py

@@ -46,6 +46,11 @@ def get_modal_content(
     ) -> JsonResponse:
         obj = self.get_object(request, object_id) if object_id else None
         action_func: Callable = getattr(self, action)
+        skip_confirmation: bool = getattr(action_func, "skip_confirmation", False)
+
+        if skip_confirmation:
+            return self.execute_modal_action(request, action, object_id)
+
         form_class: Optional[Type] = getattr(action_func, "form_class", None)
         form = form_class(request.POST or None) if form_class else None
 
@@ -201,7 +206,13 @@ def modal_action(
     modal_description: Optional[str] = None,
     permissions: Optional[Union[Callable, List[Callable]]] = None,
     form_class: Optional[Type] = None,
+    skip_confirmation: bool = False,
 ):
+    if form_class and skip_confirmation:
+        raise ValueError(
+            "Cannot use form_class with skip_confirmation. Skip confirmation means no modal and no form."
+        )
+
     def decorator(func):
         @wraps(func)
         def wrapper(self, request, queryset_or_obj, form_data=None):
@@ -211,6 +222,7 @@ def wrapper(self, request, queryset_or_obj, form_data=None):
         wrapper.modal_description = modal_description
         wrapper.permissions = permissions
         wrapper.form_class = form_class
+        wrapper.skip_confirmation = skip_confirmation
         return wrapper
 
     return decorator

django_modal_actions/static/django_modal_actions/js/modal_actions.js

@@ -83,10 +83,20 @@
         url += "?selected_ids=" + JSON.stringify(selectedIds);
       }
       $.get(url, function (data) {
-        $modalContent.html(data.content);
-        $modal.show();
-        // Initialize conditional fields after modal content is loaded
-        handleConditionalFields();
+        if (data.success !== undefined) {
+          // Skip confirmation case - action was executed directly
+          if (data.success) {
+            location.reload();
+          } else if (data.errors) {
+            displayErrors(data.errors);
+          }
+        } else if (data.content) {
+          // Normal case - show modal with confirmation
+          $modalContent.html(data.content);
+          $modal.show();
+          // Initialize conditional fields after modal content is loaded
+          handleConditionalFields();
+        }
       });
     });
 

django_modal_actions/tests/admin.py

@@ -41,8 +41,13 @@ class UserAdmin(ModalActionMixin, BaseUserAdmin):
         "object_action",
         "object_action_with_form_class",
         "conditional_fields_action",
+        "object_action_skip_confirmation",
+    ]
+    list_modal_actions = [
+        "list_action",
+        "list_action_with_form_class",
+        "list_action_skip_confirmation",
     ]
-    list_modal_actions = ["list_action", "list_action_with_form_class"]
 
     @modal_action(modal_header="Object Action")
     def object_action(self, request, obj, form_data=None):
@@ -76,6 +81,16 @@ def conditional_fields_action(self, request, obj, form_data=None):
                 return "No notification will be sent"
         return "Conditional fields action works"
 
+    @modal_action(
+        modal_header="Object Action Skip Confirmation", skip_confirmation=True
+    )
+    def object_action_skip_confirmation(self, request, obj, form_data=None):
+        return "Object action without confirmation works"
+
+    @modal_action(modal_header="List Action Skip Confirmation", skip_confirmation=True)
+    def list_action_skip_confirmation(self, request, queryset, form_data=None):
+        return f"List action without confirmation works on {queryset.count()} items"
+
 
 admin.site.unregister(User)
 admin.site.register(User, UserAdmin)

django_modal_actions/tests/test_modal_actions.py

@@ -264,6 +264,65 @@ def test_conditional_fields(self):
         )
         self.assertIn("SMS will be sent to 123-456-7890", success_message.text)
 
+    def test_skip_confirmation_object_action(self):
+        user = User.objects.first()
+        self.selenium.get(
+            self.live_server_url + reverse("admin:auth_user_change", args=[user.id])
+        )
+
+        # Click the action button
+        modal_button = WebDriverWait(self.selenium, 10).until(
+            EC.element_to_be_clickable(
+                (By.LINK_TEXT, "OBJECT ACTION SKIP CONFIRMATION")
+            )
+        )
+        modal_button.click()
+
+        # Page should reload directly without showing modal
+        # Check for success message
+        success_message = WebDriverWait(self.selenium, 10).until(
+            EC.presence_of_element_located((By.CLASS_NAME, "success"))
+        )
+        self.assertIn("Object action without confirmation works", success_message.text)
+
+        # Verify modal was never shown
+        modal = self.selenium.find_element(By.ID, "dma-modal-action")
+        self.assertFalse(modal.is_displayed())
+
+    def test_skip_confirmation_list_action(self):
+        self.selenium.get(self.live_server_url + reverse("admin:auth_user_changelist"))
+
+        # Select some users
+        checkboxes = self.selenium.find_elements(By.NAME, "_selected_action")
+        if checkboxes:
+            checkboxes[0].click()
+
+        # Click the action button
+        modal_button = WebDriverWait(self.selenium, 10).until(
+            EC.element_to_be_clickable((By.LINK_TEXT, "LIST ACTION SKIP CONFIRMATION"))
+        )
+        modal_button.click()
+
+        # Page should reload directly without showing modal
+        # Check for success message
+        success_message = WebDriverWait(self.selenium, 10).until(
+            EC.presence_of_element_located((By.CLASS_NAME, "success"))
+        )
+        self.assertIn("List action without confirmation works", success_message.text)
+
+    def test_modal_action_validation_error(self):
+        """Test that using form_class with skip_confirmation raises a ValueError"""
+        from django_modal_actions.mixins import modal_action
+        from django_modal_actions.tests.admin import CustomForm
+
+        with self.assertRaises(ValueError) as cm:
+
+            @modal_action(form_class=CustomForm, skip_confirmation=True)
+            def invalid_action(self, request, obj, form_data=None):
+                pass
+
+        self.assertIn("Cannot use form_class with skip_confirmation", str(cm.exception))
+
 
 if __name__ == "__main__":
     import unittest