added YAML linting

Author: michaelwittig

.travis.yml

@@ -0,0 +1,6 @@
+---
+language: python
+python:
+- '2.7'
+install: 'pip install yamllint'
+script: 'yamllint .'

.yamllint

@@ -0,0 +1,9 @@
+---
+extends: default
+rules:
+  indentation:
+    indent-sequences: false
+  line-length:
+    max: 999
+  comments:
+    min-spaces-from-content: 1

ecs/cluster.yaml

@@ -644,7 +644,7 @@ Resources:
               content: |
                 #!/usr/bin/env ruby
                 # chkconfig:    - 80 20
-                APP_NAME = 'lifecycle-poller'  
+                APP_NAME = 'lifecycle-poller'
                 APP_PATH = '/opt/lifecycle-poller/daemon.rb'
                 case ARGV.first
                   when 'start'
@@ -722,7 +722,7 @@ Resources:
                 def isContainerInstanceIdle(containerInstanceId)
                   ecs = Aws::ECS::Client.new()
                   resp = ecs.list_tasks({
-                    cluster: $conf['cluster'], 
+                    cluster: $conf['cluster'],
                     container_instance: containerInstanceId
                   })
                   return resp.task_arns.empty?
@@ -742,9 +742,9 @@ Resources:
                 def deregisterContainerInstance(containerInstanceId)
                   ecs = Aws::ECS::Client.new()
                   resp = ecs.deregister_container_instance({
-                    cluster: $conf['cluster'], 
-                    container_instance: containerInstanceId, 
-                    force: false 
+                    cluster: $conf['cluster'],
+                    container_instance: containerInstanceId,
+                    force: false
                   })
                 end
                 def completeLifecycleAction(token, hook, asg)

ecs/service-cluster-alb.yaml

@@ -95,7 +95,7 @@ Conditions:
 Resources:
   TaskDefinition:
     Type: 'AWS::ECS::TaskDefinition'
-    Properties: 
+    Properties:
       Family: !Ref 'AWS::StackName'
       NetworkMode: bridge
       ContainerDefinitions:
@@ -129,8 +129,8 @@ Resources:
       VpcId:
         'Fn::ImportValue': !Sub '${ParentClusterStack}-VPC'
       TargetGroupAttributes:
-        - Key: deregistration_delay.timeout_seconds
-          Value: !Ref LoadBalancerDeregistrationDelay
+      - Key: deregistration_delay.timeout_seconds
+        Value: !Ref LoadBalancerDeregistrationDelay
   LoadBalancerHttpListenerRule:
     Type: 'AWS::ElasticLoadBalancingV2::ListenerRule'
     Properties:
@@ -263,7 +263,7 @@ Resources:
       PolicyName: !Sub '${AWS::StackName}-scale-up'
       PolicyType: StepScaling
       ScalingTargetId: !Ref ScalableTarget
-      StepScalingPolicyConfiguration: 
+      StepScalingPolicyConfiguration:
         AdjustmentType: PercentChangeInCapacity
         Cooldown: 300
         MinAdjustmentMagnitude: 1
@@ -276,7 +276,7 @@ Resources:
       PolicyName: !Sub '${AWS::StackName}-scale-down'
       PolicyType: StepScaling
       ScalingTargetId: !Ref ScalableTarget
-      StepScalingPolicyConfiguration: 
+      StepScalingPolicyConfiguration:
         AdjustmentType: PercentChangeInCapacity
         Cooldown: 300
         MinAdjustmentMagnitude: 1
@@ -355,7 +355,7 @@ Outputs:
     Description: 'URL to the ECS service.' # TODO does not work with LoadBalancerHostPattern
     Value: !Sub
     - '${ClusterURL}/${LoadBalancerPath}/'
-    - ClusterURL: 
+    - ClusterURL:
         'Fn::ImportValue': !Sub '${ParentClusterStack}-URL'
       LoadBalancerPath: !Ref LoadBalancerPath
     Export:

ecs/service-dedicated-alb.yaml

@@ -90,7 +90,7 @@ Conditions:
 Resources:
   TaskDefinition:
     Type: 'AWS::ECS::TaskDefinition'
-    Properties: 
+    Properties:
       Family: !Ref 'AWS::StackName'
       NetworkMode: bridge
       ContainerDefinitions:
@@ -177,8 +177,8 @@ Resources:
       VpcId:
         'Fn::ImportValue': !Sub '${ParentVPCStack}-VPC'
       TargetGroupAttributes:
-        - Key: deregistration_delay.timeout_seconds
-          Value: !Ref LoadBalancerDeregistrationDelay
+      - Key: deregistration_delay.timeout_seconds
+        Value: !Ref LoadBalancerDeregistrationDelay
   HTTPCodeELB5XXTooHighAlarm:
     Condition: HasAlertTopic
     Type: 'AWS::CloudWatch::Alarm'
@@ -326,7 +326,7 @@ Resources:
       PolicyName: !Sub '${AWS::StackName}-scale-up'
       PolicyType: StepScaling
       ScalingTargetId: !Ref ScalableTarget
-      StepScalingPolicyConfiguration: 
+      StepScalingPolicyConfiguration:
         AdjustmentType: PercentChangeInCapacity
         Cooldown: 300
         MinAdjustmentMagnitude: 1
@@ -339,7 +339,7 @@ Resources:
       PolicyName: !Sub '${AWS::StackName}-scale-down'
       PolicyType: StepScaling
       ScalingTargetId: !Ref ScalableTarget
-      StepScalingPolicyConfiguration: 
+      StepScalingPolicyConfiguration:
         AdjustmentType: PercentChangeInCapacity
         Cooldown: 300
         MinAdjustmentMagnitude: 1

jenkins/jenkins2-ha-agents.yaml

@@ -723,7 +723,7 @@ Resources:
               content: |
                 #!/usr/bin/env ruby
                 # chkconfig:    - 80 20
-                APP_NAME = 'lifecycle-poller'  
+                APP_NAME = 'lifecycle-poller'
                 APP_PATH = '/opt/lifecycle-poller/daemon.rb'
                 case ARGV.first
                   when 'start'
@@ -1452,7 +1452,7 @@ Resources:
               content: |
                 #!/usr/bin/env ruby
                 # chkconfig:    - 80 20
-                APP_NAME = 'agent-healthcheck'  
+                APP_NAME = 'agent-healthcheck'
                 APP_PATH = '/opt/agent-healthcheck/daemon.rb'
                 case ARGV.first
                   when 'start'

jenkins/jenkins2-ha.yaml

@@ -191,7 +191,7 @@ Resources:
       FileSystemId: !Ref MasterStorage
       SecurityGroups:
       - !Ref MasterStorageSG
-      SubnetId: 
+      SubnetId:
         'Fn::ImportValue': !Sub '${ParentVPCStack}-SubnetA${MasterSubnetsReach}'
   MasterStorageMountTargetB:
     Type: 'AWS::EFS::MountTarget'

mkdocs.yml

@@ -3,13 +3,13 @@
 site_name: 'Free Templates for AWS CloudFormation'
 docs_dir: 'docs'
 pages:
-  - 'Home': 'index.md'
-  - 'EC2': 'ec2.md'
-  - 'ECS': 'ecs.md'
-  - 'Jenkins': 'jenkins.md'
-  - 'Operations': 'operations.md'
-  - 'Security': 'security.md'
-  - 'Static Website': 'static-website.md'
-  - 'VPC': 'vpc.md'
-  - 'WordPress': 'wordpress.md'
-  - 'Migrate to v4': 'migrate-v4.md'
+- 'Home': 'index.md'
+- 'EC2': 'ec2.md'
+- 'ECS': 'ecs.md'
+- 'Jenkins': 'jenkins.md'
+- 'Operations': 'operations.md'
+- 'Security': 'security.md'
+- 'Static Website': 'static-website.md'
+- 'VPC': 'vpc.md'
+- 'WordPress': 'wordpress.md'
+- 'Migrate to v4': 'migrate-v4.md'

static-website/static-website.yaml

@@ -47,7 +47,7 @@ Resources:
   Certificate:
     Condition: HasCreateAcmCertificate
     Type: 'AWS::CertificateManager::Certificate'
-    Properties: 
+    Properties:
       DomainName: !Ref DomainName
       DomainValidationOptions: !If
       - HasRedirectDomainName
@@ -84,7 +84,7 @@ Resources:
         - !Ref DomainName
         Comment: !Ref DomainName
         Origins:
-        - DomainName: !Select [ 2, !Split [ /, !GetAtt S3Bucket.WebsiteURL ] ]
+        - DomainName: !Select [2, !Split ['/', !GetAtt 'S3Bucket.WebsiteURL']]
           Id: s3origin
           CustomOriginConfig:
             OriginProtocolPolicy: 'http-only'
@@ -107,8 +107,8 @@ Resources:
         HttpVersion: http2
         PriceClass: 'PriceClass_All'
         ViewerCertificate:
-          AcmCertificateArn: !If [HasCreateAcmCertificate, !Ref Certificate, !If [HasAcmCertificateArn, !Ref ExistingCertificate, !Ref 'AWS::NoValue']] 
-          IamCertificateId: !If [HasIamCertificateId, !Ref ExistingCertificate, !Ref 'AWS::NoValue'] 
+          AcmCertificateArn: !If [HasCreateAcmCertificate, !Ref Certificate, !If [HasAcmCertificateArn, !Ref ExistingCertificate, !Ref 'AWS::NoValue']]
+          IamCertificateId: !If [HasIamCertificateId, !Ref ExistingCertificate, !Ref 'AWS::NoValue']
           SslSupportMethod: 'sni-only'
           MinimumProtocolVersion: TLSv1
   Route53Record:
@@ -140,7 +140,7 @@ Resources:
         - !Ref RedirectDomainName
         Comment: !Ref RedirectDomainName
         Origins:
-        - DomainName: !Select [ 2, !Split [ /, !GetAtt S3BucketRedirect.WebsiteURL ] ]
+        - DomainName: !Select [2, !Split ['/', !GetAtt 'S3BucketRedirect.WebsiteURL']]
           Id: s3origin
           CustomOriginConfig:
             OriginProtocolPolicy: 'http-only'
@@ -163,8 +163,8 @@ Resources:
         HttpVersion: http2
         PriceClass: 'PriceClass_All'
         ViewerCertificate:
-          AcmCertificateArn: !If [HasCreateAcmCertificate, !Ref Certificate, !If [HasAcmCertificateArn, !Ref ExistingCertificate, !Ref 'AWS::NoValue']] 
-          IamCertificateId: !If [HasIamCertificateId, !Ref ExistingCertificate, !Ref 'AWS::NoValue'] 
+          AcmCertificateArn: !If [HasCreateAcmCertificate, !Ref Certificate, !If [HasAcmCertificateArn, !Ref ExistingCertificate, !Ref 'AWS::NoValue']]
+          IamCertificateId: !If [HasIamCertificateId, !Ref ExistingCertificate, !Ref 'AWS::NoValue']
           SslSupportMethod: 'sni-only'
           MinimumProtocolVersion: TLSv1
   Route53RecordRedirect:

vpc/vpc-2azs-legacy.yaml

@@ -63,7 +63,7 @@ Parameters:
 Resources:
   Dummy:
     Type: 'AWS::S3::Bucket'
-    Properties: 
+    Properties:
       BucketName: !Ref 'AWS::StackName'
 Outputs:
   TemplateID: