Update eslint-config-minecraft-scripting to lint config files, extend config in core-build-tasks (#78)

Author: zachcampbellskyboxlabs

change/@minecraft-api-docs-generator-aeac4840-1694-45da-bab2-881c32116669.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Linting fixes",
+  "packageName": "@minecraft/api-docs-generator",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@minecraft-core-build-tasks-97cf4abd-65fe-4953-b8b9-e0c2f8be3ea8.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Update coreLint task to run on whole working directory, linting fixes",
+  "packageName": "@minecraft/core-build-tasks",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@minecraft-markup-generators-plugin-3708f9ff-73c2-4e26-87a0-bbaf54190aac.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Linting fixes",
+  "packageName": "@minecraft/markup-generators-plugin",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/@minecraft-math-34b482b5-943a-4afc-875a-8dd0b3bca106.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "Linting fixes",
+  "packageName": "@minecraft/math",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

change/eslint-plugin-minecraft-linting-bacdf915-6b2c-4662-a22b-964b0fff49f0.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Update dependencies",
+  "packageName": "eslint-plugin-minecraft-linting",
+  "email": "[email protected]",
+  "dependentChangeType": "none"
+}

libraries/math/eslint.config.mjs

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
 import configMinecraftScripting from 'eslint-config-minecraft-scripting';
 
 export default [...configMinecraftScripting];

libraries/math/just.config.cts

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
 import { execSync } from 'child_process';
 import { argv, series, task, tscTask } from 'just-scripts';
 import {
@@ -8,7 +11,7 @@ import {
     publishReleaseTask,
     vitestTask,
 } from '@minecraft/core-build-tasks';
-import { copyFileSync, createWriteStream, readFileSync } from 'node:fs';
+import { copyFileSync, readFileSync } from 'node:fs';
 import { resolve } from 'node:path';
 
 const isOnlyBuild = argv()._.findIndex(arg => arg === 'test') === -1;

libraries/math/src/vector3/coreHelpers.ts

@@ -184,8 +184,8 @@ export class Vector3Utils {
      * @param a - Angle in radians
      */
     static rotateX(v: Vector3, a: number): Vector3 {
-        let cos = Math.cos(a);
-        let sin = Math.sin(a);
+        const cos = Math.cos(a);
+        const sin = Math.sin(a);
         return { x: v.x, y: v.y * cos - v.z * sin, z: v.z * cos + v.y * sin };
     }
 
@@ -196,8 +196,8 @@ export class Vector3Utils {
      * @param a - Angle in radians
      */
     static rotateY(v: Vector3, a: number): Vector3 {
-        let cos = Math.cos(a);
-        let sin = Math.sin(a);
+        const cos = Math.cos(a);
+        const sin = Math.sin(a);
         return { x: v.x * cos + v.z * sin, y: v.y, z: v.z * cos - v.x * sin };
     }
 
@@ -208,8 +208,8 @@ export class Vector3Utils {
      * @param a - Angle in radians
      */
     static rotateZ(v: Vector3, a: number): Vector3 {
-        let cos = Math.cos(a);
-        let sin = Math.sin(a);
+        const cos = Math.cos(a);
+        const sin = Math.sin(a);
         return { x: v.x * cos - v.y * sin, y: v.y * cos + v.x * sin, z: v.z };
     }
 }

libraries/math/vite.config.mts

@@ -1,3 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT License.
+
 /// <reference types="vitest" />
 import { configDefaults, defineConfig } from 'vitest/config';