Don't sync unconfirmed txids when syncing bdk

Author: benthecarman

mutiny-core/src/onchain.rs

@@ -168,30 +168,15 @@ impl<S: MutinyStorage> OnChainWallet<S> {
             self.storage.delete(&[NEED_FULL_SYNC_KEY])?;
         }
         // get first wallet lock that only needs to read
-        let (spks, txids, chain, prev_tip) = {
+        let (spks, chain, prev_tip) = {
             if let Ok(wallet) = self.wallet.try_read() {
                 let spk_vec = wallet
                     .spk_index()
                     .unused_spks()
                     .map(|(_, _, v)| ScriptBuf::from(v))
                     .collect::<Vec<_>>();
 
-                let chain = wallet.local_chain();
-                let chain_tip = chain.tip().block_id();
-
-                let unconfirmed_txids = wallet
-                    .tx_graph()
-                    .list_chain_txs(chain, chain_tip)
-                    .filter(|canonical_tx| !canonical_tx.chain_position.is_confirmed())
-                    .map(|canonical_tx| canonical_tx.tx_node.txid)
-                    .collect::<Vec<Txid>>();
-
-                (
-                    spk_vec,
-                    unconfirmed_txids,
-                    chain.clone(),
-                    wallet.latest_checkpoint(),
-                )
+                (spk_vec, wallet.local_chain(), wallet.latest_checkpoint())
             } else {
                 log_error!(self.logger, "Could not get wallet lock to sync");
                 return Err(MutinyError::WalletOperationFailed);
@@ -200,7 +185,7 @@ impl<S: MutinyStorage> OnChainWallet<S> {
 
         let update_graph = self
             .blockchain
-            .sync(spks, txids, core::iter::empty(), 5)
+            .sync(spks, core::iter::empty(), core::iter::empty(), 5)
             .await?;
         let missing_heights = update_graph.missing_heights(&chain);
         let chain_update = self