Skip to content

EVR streams by module can have mismatched case on the module subscription #392

@mudinthewater

Description

@mudinthewater

Describe the defect

When OMM subscribes to an evr stream by module, the code checks the module from the EVR dictionary and pegs it to lowercase:
domainObject.telemetry.definition.module.toLowerCase();

This appears to be to ensure that subsequent subscriptions to MCWS' EVR stream endpoint are lowercase. However, MCWS's AbstractStreamEndpointAdapter already converts all filters to lowercase, which means this conversion isn't needed on OMM's end - and indeed it's not used for either channels or evrs by level in OMM.

Due to OMM converting the module to lowercase, there's a mismatch on the key of the returned evr data.

Example:
module = TEST
omm internal subscription: test
request to mcws filter: module=test
subscribers[test]
key: TEST

This is the behavior that breaks subscriptions on the top level EVR object and EVR queries by module or name.

Expected behavior

EVR module subscriptions should be always all caps. This is consistent with both historical queries and other EVR filters. I tested this against NISAR MCWS realtime and verified that all caps module subscriptions are identical to all lowercase module subscriptions.

Steps To Reproduce

  1. Use any EVR module where the module in AMPCS is in all caps.

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    defectevery defect must have an accompanying criticality, or `crit-`

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions