Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of ‘Show 100’, ‘CSV’, ‘CUSTOMIZE COLUMNS’ #1242

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

saifrk
Copy link
Collaborator

@saifrk saifrk commented Mar 2, 2025

Fixes issue #1196
image

…ns-boxes-to-be-in-one-line-on-the-delta-urls-page
align-items: center !important;
}

#exclude_patterns_table_wrapper,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain these additional css modifications? How do they affect the ordering of Show 100, CSV, and Customize Columns?

Copy link
Collaborator Author

@saifrk saifrk Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brief description of all modifications made:

  • The .dt-container sets 'position: relative' on the .dt-container element which establishes the container as the positional reference for any child elements that are positioned absolutely(Any child with 'position: absolute' will be positioned relative to the boundaries of .dt-container, not the entire page)
  • The .dt-container div.dt-buttons handles the alignment of the "Show 100" "CSV" and "Customize CSV" buttons. It uses 'flexbox' to arrange the buttons in a row, spaces them with 'gap', centers them vertically with 'align-items: center' and positions the group at the top right corner of its container with 'position: absolute' and 'justify-content: flex-end'
  • The Updated styling includes modifications to properties like margin and display settings
  • The subsequent code is associated with adjusting spacing and positioning as needed, due to the absolute positioning of .dt-buttons affecting the original placement of 'Add Pattern' and 'Customize Columns' in the Exclude/Include/Title pattern sections.

Your Name and others added 5 commits March 6, 2025 19:47
…o-be-in-one-line-on-the-delta-urls-page' of https://github.com/NASA-IMPACT/COSMOS into 1196-arrange-the-show-100-csv-customize-columns-boxes-to-be-in-one-line-on-the-delta-urls-page
…ns-boxes-to-be-in-one-line-on-the-delta-urls-page
…o-be-in-one-line-on-the-delta-urls-page' of https://github.com/NASA-IMPACT/COSMOS into 1196-arrange-the-show-100-csv-customize-columns-boxes-to-be-in-one-line-on-the-delta-urls-page
@CarsonDavis
Copy link
Collaborator

Let's update this in the following way:

  • everything should be in a single line, starting with Showing 0 of x Entries on the far left, then the Show 100 button next to it
  • on the right will appear the CSV and the Customize Columns buttons
  • each of these should have the same padding between the bottom of the element and the top of the table
  • on the left and right sides of the table, the elements should be aligned. Where the table begins on the right is where the text should be. Where the table ends on the left is where the buttons should end.
  • put all the buttons and text in the same div and design that div.

@saifrk
Copy link
Collaborator Author

saifrk commented Mar 8, 2025

Alignment after the latest update is as attached:
image

Note: In the far left, I have placed 'Show100' and then 'Showing 0 of x Entries' to its next, to maintain consistency with other sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrange the ‘Show 100’, ‘CSV’, ‘CUSTOMIZE COLUMNS’ boxes to be in one line on the delta urls page
2 participants