cp: [training] fix: Route batches to standalone MTP stages (4208) into r0.5.0#4225
Open
svcnvidia-nemo-ci wants to merge 1 commit into
Open
cp: [training] fix: Route batches to standalone MTP stages (4208) into r0.5.0#4225svcnvidia-nemo-ci wants to merge 1 commit into
[training] fix: Route batches to standalone MTP stages (4208) into r0.5.0#4225svcnvidia-nemo-ci wants to merge 1 commit into
Conversation
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Contributor
Author
|
/ok to test d447cfa |
yaoyu-33
added
area:training
Contributor
|
/claude review |
Contributor
Code Review — PR #4225Summary: Cherry-pick of #4208. Adds stage-aware MTP batch routing so only PP stages that own MTP layers receive token/position_id tensors, instead of broadcasting them to all stages when use_mtp=True. Three new helper functions and four new unit tests. No critical bugs or logic errors found. LGTM. Minor observations (non-blocking)
Suggested test casesNo perf tests impacted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [🤖]: Hi @yaoyu-33 👋,