Skip to content

Commit 2998718

Browse files
committed
ci: Fix name of badge for upstream-maxtext
1 parent ecc5628 commit 2998718

File tree

2 files changed

+15
-16
lines changed

2 files changed

+15
-16
lines changed

.github/workflows/_test_upstream_maxtext.yaml

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ on:
1111
EXTRA_TEST_ARGS:
1212
type: string
1313
description: Extra command line args to pass to test-maxtext.sh
14-
default: ""
14+
default: ''
1515
required: false
1616
BADGE_FILENAME:
1717
type: string
1818
description: 'Name of the endpoint JSON file for shields.io badge'
1919
required: false
20-
default: 'badge-maxtext-test.json'
20+
default: 'badge-upstream-maxtext-test.json'
2121
ARTIFACT_NAME:
2222
type: string
2323
description: 'Name of the artifact zip file'
@@ -34,12 +34,11 @@ on:
3434
value: ${{ jobs.sitrep.outputs.STATUS }}
3535

3636
jobs:
37-
3837
single-process-multi-device:
3938
strategy:
4039
matrix:
4140
PARALLEL_CONFIG:
42-
- [1, 1, 2, 4]
41+
- [1, 1, 2, 4]
4342
# - [1, 1, 1, 8] # PP, DP, FSDP, TP
4443
fail-fast: false
4544

@@ -183,12 +182,12 @@ jobs:
183182
strategy:
184183
matrix:
185184
PARALLEL_CONFIG:
186-
- [1, 1, 1, 1]
187-
- [1, 1, 8, 1]
188-
- [1, 1, 1, 8]
189-
- [1, 1, 4, 2]
190-
- [1, 2, 2, 2]
191-
- [1, 4, 2, 2]
185+
- [1, 1, 1, 1]
186+
- [1, 1, 8, 1]
187+
- [1, 1, 1, 8]
188+
- [1, 1, 4, 2]
189+
- [1, 2, 2, 2]
190+
- [1, 4, 2, 2]
192191
fail-fast: false
193192

194193
runs-on: ubuntu-22.04
@@ -366,7 +365,7 @@ jobs:
366365
367366
sitrep:
368367
needs: [single-process-multi-device, maxtext-multinode, metrics]
369-
if: "!cancelled()"
368+
if: '!cancelled()'
370369
uses: ./.github/workflows/_sitrep_mgmn.yaml
371370
secrets: inherit
372371
with:
@@ -377,7 +376,7 @@ jobs:
377376
summary:
378377
runs-on: ubuntu-22.04
379378
needs: [single-process-multi-device, maxtext-multinode]
380-
if: "!cancelled()"
379+
if: '!cancelled()'
381380
steps:
382381
- name: Generate TensorBoard query URL
383382
run: |
@@ -394,7 +393,7 @@ jobs:
394393
outcome:
395394
needs: sitrep
396395
runs-on: ubuntu-22.04
397-
if: "!cancelled()"
396+
if: '!cancelled()'
398397
steps:
399398
- name: Sets workflow status based on test outputs
400399
run: |

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@
222222
<code>ghcr.io/nvidia/jax:upstream-maxtext</code>
223223
</td>
224224
<td>
225-
<a href="https://gist.github.com/nvjax/913c2af68649fe568e9711c2dabb23ae/#file-final-maxtext-md"><img style="height:1em;" src="https://img.shields.io/endpoint?url=https%3A%2F%2Fgist.githubusercontent.com%2Fnvjax%2F913c2af68649fe568e9711c2dabb23ae%2Fraw%2Fbadge-upstream-maxtext-build-amd64.json&logo=docker&label=amd64"></a>
225+
<a href="https://gist.github.com/nvjax/913c2af68649fe568e9711c2dabb23ae/#file-final-upstream-maxtext-md"><img style="height:1em;" src="https://img.shields.io/endpoint?url=https%3A%2F%2Fgist.githubusercontent.com%2Fnvjax%2F913c2af68649fe568e9711c2dabb23ae%2Fraw%2Fbadge-upstream-maxtext-build-amd64.json&logo=docker&label=amd64"></a>
226226
<img style="height:1em;" src="https://img.shields.io/endpoint?url=https%3A%2F%2Fgist.githubusercontent.com%2Fnvjax%2F913c2af68649fe568e9711c2dabb23ae%2Fraw%2Fbadge-upstream-maxtext-build-arm64.json&logo=docker&label=arm64">
227227
</td>
228228
<td>
@@ -241,8 +241,8 @@
241241
<code>ghcr.io/nvidia/jax:maxtext</code>
242242
</td>
243243
<td>
244-
<a href="https://gist.github.com/nvjax/913c2af68649fe568e9711c2dabb23ae/#file-final-maxtext-md"><img style="height:1em;" src="https://img.shields.io/endpoint?url=https%3A%2F%2Fgist.githubusercontent.com%2Fnvjax%2F913c2af68649fe568e9711c2dabb23ae%2Fraw%2Fbadge-rosetta-maxtext-build-amd64.json&logo=docker&label=amd64"></a>
245-
<img style="height:1em;" src="https://img.shields.io/endpoint?url=https%3A%2F%2Fgist.githubusercontent.com%2Fnvjax%2F913c2af68649fe568e9711c2dabb23ae%2Fraw%2Fbadge-rosetta-maxtext-build-arm64.json&logo=docker&label=arm64">
244+
<a href="https://gist.github.com/nvjax/913c2af68649fe568e9711c2dabb23ae/#file-final-md"><img style="height:1em;" src="https://img.shields.io/endpoint?url=https%3A%2F%2Fgist.githubusercontent.com%2Fnvjax%2F913c2af68649fe568e9711c2dabb23ae%2Fraw%2Fbadge-rosetta-build-amd64.json&logo=docker&label=amd64"></a>
245+
<img style="height:1em;" src="https://img.shields.io/endpoint?url=https%3A%2F%2Fgist.githubusercontent.com%2Fnvjax%2F913c2af68649fe568e9711c2dabb23ae%2Fraw%2Fbadge-rosetta-build-arm64.json&logo=docker&label=arm64">
246246
</td>
247247
<td>
248248
<picture>

0 commit comments

Comments
 (0)