Skip to content

Commit 6fee7c1

Browse files
ko3n1gterrykong
andcommitted
Update rosetta/Dockerfile.maxtext
Co-authored-by: Terry Kong <[email protected]>
1 parent 9514f68 commit 6fee7c1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/_ci.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ jobs:
8686
BADGE_FILENAME: badge-maxtext-build
8787
BUILD_DATE: ${{ inputs.BUILD_DATE }}
8888
BASE_IMAGE: ${{ needs.build-jax.outputs.DOCKER_TAG_MEALKIT }}
89-
CONTAINER_NAME: maxtext
89+
CONTAINER_NAME: upstream-maxtext
9090
DOCKERFILE: .github/container/Dockerfile.maxtext.amd64
9191
secrets: inherit
9292

@@ -184,8 +184,10 @@ jobs:
184184
- build-levanter
185185
- build-upstream-t5x
186186
- build-upstream-pax
187+
- build-upstream-maxtext
187188
- build-rosetta-t5x
188189
- build-rosetta-pax
190+
- build-rosetta-maxtext
189191
- build-grok
190192
outputs:
191193
TAGS: ${{ steps.collect-tags.outputs.TAGS }}

rosetta/Dockerfile.maxtext

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# syntax=docker/dockerfile:1-labs
2-
ARG BASE_IMAGE=ghcr.io/nvidia/jax-mealkit:upstream-pax
2+
ARG BASE_IMAGE=ghcr.io/nvidia/jax-mealkit:upstream-maxtext
33
44
ARG GIT_USER_NAME=NVIDIA
55
# If set to "true", then will pull new local patches, the manifest.yaml and create-distribution.sh (in case it was updated).
@@ -35,8 +35,6 @@ if [[ "${UPDATE_PATCHES}" == "true" ]]; then
3535
cp -r /mnt/jax-toolbox/.github/container/patches ${MANIFEST_DIR}/
3636
cp /mnt/jax-toolbox/.github/container/manifest.yaml ${MANIFEST_DIR}/manifest.yaml
3737
cp /mnt/jax-toolbox/.github/container/create-distribution.sh ${MANIFEST_DIR}/create-distribution.sh
38-
# TODO: remove
39-
cp /mnt/jax-toolbox/.github/container/pip-finalize.sh /usr/local/bin/
4038
fi
4139
cp -r /mnt/jax-toolbox/rosetta /opt/rosetta
4240

0 commit comments

Comments
 (0)