Skip to content

Conversation

@terrykong
Copy link
Contributor

@terrykong terrykong commented Nov 9, 2023

Currently, we only report "completion" badges for upstream tests, which mistakenly reported "n/a" if there was one failure. We also performed loss/perf tests for upstream but did not report it.

This change:

  • simplifies the workflows by removing that extra completion badge step and re-uses the badge within _test_t5x.yaml and _test_pax.yaml
  • renames the badge labels to "Upstream tests" for upstream-{t5x,pax} and "Tests" for rosetta ones.
  • Will now surface loss/perf test status in upstream badges
  • [] Dry run with fake badge endpoint names

@terrykong
Copy link
Contributor Author

Copy link
Contributor

@ashors1 ashors1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Collaborator

@yhtang yhtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR going to be superceded by #401?

with:
ENDPOINT_FILENAME: 'pax-test-status.json'
PUBLISH: false
ENDPOINT_FILENAME: 'upstream-pax-test-overall-status.deleteme.json'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is that deleteme infix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants