feat: refactor validators and fields to support pydantic v2 #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaobo8204
changed the title
1 task
|
@xiaobo8204 thanks for your contribution to NeMo Guardrails 👍🏻 would you please sign all your commits following the contributing guidelines. You should see a Verified tag for all your commits. |
Pouyanpi
reviewed
Feb 3, 2025
Pouyanpi
reviewed
Feb 3, 2025
Pouyanpi
reviewed
Feb 3, 2025
| @@ -65,7 +65,7 @@ langchain-community = ">=0.0.16,<0.4.0" | |||
| lark = ">=1.1.7" | |||
| nest-asyncio = ">=1.5.6," | |||
| prompt-toolkit = ">=3.0" | |||
| pydantic = ">=1.10" | |||
There was a problem hiding this comment.
we should relax it a bit, probably >= 2.0
And I still need to see the reasons we were still supporting Pydantic 1.0, I'll get back to this later.
There was a problem hiding this comment.
removed the extra log.text and hidden file, changed the version to >= 2.0, and signed the commit, thanks...
Pouyanpi
changed the title
xiaobo8204
force-pushed
the
feature/xiaobo_dev_features
branch
from
c5a4d19 to
8581787
Compare
- Refactored code to use `@model_validator` instead of `@root_validator` - Updated `Field` usage to align with Pydantic v2 standards - Modified validation logic to comply with the new API - Updated `poetry.lock` and dependencies in `pyproject.toml`
xiaobo8204
force-pushed
the
feature/xiaobo_dev_features
branch
from
8581787 to
bb87907
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to update Pydantic to the latest v2.10.6, and switch to use the new model_validator/Field/field_validator in the new Pydantic version.
Related Issue(s)
Checklist