[None][docs] Fix beamWidth default value and valid range in gpt-runtime.md#14493
Open
fuergaosi233 wants to merge 1 commit into
Open
[None][docs] Fix beamWidth default value and valid range in gpt-runtime.md#14493fuergaosi233 wants to merge 1 commit into
fuergaosi233 wants to merge 1 commit into
Conversation
…me.md Signed-off-by: holegots <fuergaosi@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the documentation for the ChangesbeamWidth Parameter Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
docs/source/legacy/advanced/gpt-runtime.mddocumentsbeamWidthwith an incorrect default value and an invalid minimum range. The table states:However, the C++ source code tells a different story.
Code Evidence
cpp/include/tensorrt_llm/runtime/samplingConfig.h:The code:
beamWidthto 1 (not 0)beamWidth > 0— value 0 is INVALID and triggers an errorbeamWidth = 1, not 0Changes
[0, 1024]to[1, 1024]0to1samplingConfig.hSummary by CodeRabbit
beamWidthparameter documentation with revised default value, allowed range, and clarification on beam search behavior.